Skip to content

Extend weak content check for tool needs#158

Closed
Aymen-Soussi-01 wants to merge 9 commits into
eclipse-score:mainfrom
Aymen-Soussi-01:extend-weak-content-check-for-tool-needs
Closed

Extend weak content check for tool needs#158
Aymen-Soussi-01 wants to merge 9 commits into
eclipse-score:mainfrom
Aymen-Soussi-01:extend-weak-content-check-for-tool-needs

Conversation

@Aymen-Soussi-01
Copy link
Copy Markdown
Contributor

Extend weak content check for tool needs and correct failed Tool requirements in the build

close: #148

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 23, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ✅ Passed

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 78b913d7-8cb6-4f4f-b3a5-ce3e1b66e626
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (96 packages loaded, 10 targets configured)

Analyzing: target //src:license-check (109 packages loaded, 17 targets configured)

Analyzing: target //src:license-check (148 packages loaded, 1598 targets configured)

Analyzing: target //src:license-check (158 packages loaded, 2683 targets configured)

Analyzing: target //src:license-check (158 packages loaded, 2687 targets configured)

Analyzing: target //src:license-check (162 packages loaded, 4820 targets configured)

INFO: Analyzed target //src:license-check (163 packages loaded, 4946 targets configured).
[10 / 13] JavaToolchainCompileClasses external/rules_java~/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[11 / 13] JavaToolchainCompileBootClasspath external/rules_java~/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 18.233s, Critical Path: 2.56s
INFO: 13 processes: 1 disk cache hit, 9 internal, 2 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt -review -project automotive.score -repo https://github.com/eclipse-score/docs-as-code -token otyhZ4eaRYK1tKLNNF-Y
[main] INFO Querying Eclipse Foundation for license data for 83 items.
[main] INFO Found 58 items.
[main] INFO Querying ClearlyDefined for license data for 25 items.
[main] INFO Found 25 items.
[main] INFO Vetted license information was found for all content. No further investigation is required.

- requirement_excl_process

# req-Id: tool_req__docs_req_types
aou_req:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not aou? Any other missing?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the list of the requirement we need to cover not all of them I didn't want the new tag name to be more longer or I can exclude aou also in the name: https://eclipse-score.github.io/docs-as-code/pr-140/product/requirements.html#tool_req__docs_req_weak_content

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did add AOU I think in my PR, as I saw it missing.
But we can double check it.

@github-actions
Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@Aymen-Soussi-01 Aymen-Soussi-01 force-pushed the extend-weak-content-check-for-tool-needs branch from 4b158ad to 9a2f672 Compare July 23, 2025 09:58
@MaximilianSoerenPollak
Copy link
Copy Markdown
Contributor

/consumer-test

1 similar comment
@MaximilianSoerenPollak
Copy link
Copy Markdown
Contributor

/consumer-test

Comment thread docs/product/requirements.rst
Comment on lines +134 to +137
need_options = get_need_type(app.config.needs_types, need["type"])

tags = need_options.get("tags", [])
if "requirement_excl_process" in tags and need.get("content", None):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not quiet right.
As we want the 'requirement_excl_process' to be inside the metamodel defined not here.

Basically do not want to change python code if we want to change which needs or what words are affected.

@MaximilianSoerenPollak
Copy link
Copy Markdown
Contributor

This has been merged in collaboration PR #173.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

tool_req__docs_req_weak_content: Check weak content for needs

3 participants