Skip to content

7 cece363 f0 ee64 ee11 a5 b7 ec828632 dd 2#101

Closed
Y-Vaishnavi wants to merge 47 commits into
eclipse-score:mainfrom
Y-Vaishnavi:7CECE363F0EE64EE11A5B7EC828632DD_2
Closed

7 cece363 f0 ee64 ee11 a5 b7 ec828632 dd 2#101
Y-Vaishnavi wants to merge 47 commits into
eclipse-score:mainfrom
Y-Vaishnavi:7CECE363F0EE64EE11A5B7EC828632DD_2

Conversation

@Y-Vaishnavi
Copy link
Copy Markdown
Contributor

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

rmaddikery and others added 30 commits April 29, 2026 07:15
- project sensitve text transformations moved

GIT_ORIGIN_SPP_REV_ID: aa2000a352b30bf9283ea522b521b1a475eb9bba
See references

GIT_ORIGIN_SPP_REV_ID: 378074819076deffb569e20b54d37e2edece9403
GIT_ORIGIN_SPP_REV_ID: de390e754f7496c9e63898fa8765ddd3bbdf2aec
Replace banned OS calls with OSAL equivalents, remove banned pragmas,
add explicit constructors and member initialization defaults, and
handle SIGTERM via SigWait to avoid SigAction. Also add a string literal
overload to avoid array decay in log conversion.

Tested: bazel build --config=spp_host_gcc //platform/aas/pas/logging:datarouter
Tested: bazel build --config=arm64_qnx8 //platform/aas/pas/logging:unixdomain_server
GIT_ORIGIN_SPP_REV_ID: a4b7b518a897c0038ce99fcd23133b3007a84ecd
GIT_ORIGIN_SPP_REV_ID: 2a88f88348334f8f330497c6768a829c2c8dd7ee
updated the bazelrc file and other visibilities
tested by building the ddad and checking for build issue

GIT_ORIGIN_SPP_REV_ID: 29c5aee994cca89901362f43b0b7c4bdda96ba6c
GIT_ORIGIN_SPP_REV_ID: b9250202f7a761b45a6ecac867ecb8264a8ab3a5
- Move synchronized utility and tests to platform/aas/lib/concurrency

GIT_ORIGIN_SPP_REV_ID: 8a552bad85f4b8e722b26a687f6255f86be01a67
GIT_ORIGIN_SPP_REV_ID: 250492b205efbe4e60c1fcb9180f4f6573237e5f
GIT_ORIGIN_SPP_REV_ID: 7c2c3f5d6b5f1c41dbfe64ba5750657e2b0bc442
GIT_ORIGIN_SPP_REV_ID: 88f62b029a81185ad39a07b2a833a9cfa68a44f3
- Removed noexcept specifier.

GIT_ORIGIN_SPP_REV_ID: ae5e6601dc66bfa36f26c4fbce75244b61ad55f0
GIT_ORIGIN_SPP_REV_ID: 9c315ca392f22c02945d6de0995d5467289317da
Updated wait_free_producer_queue

GIT_ORIGIN_SPP_REV_ID: 2e6de641e25d85584a47c286d7a3ab94d7e88137
Diagrams in datarouter beckend converted

GIT_ORIGIN_SPP_REV_ID: 9dcad4a904ee1d827b173e1098b0b958461a2c68
If we want to make sure that the rules C++ and Python loaded are the
version we defined and not the one in Bazel, we need to explicitly
add the load statement.
This also becomes mandatory in Bazel 9.

These changes have been done automatically with buildifier fix after
adding native-cc and native-py.

GIT_ORIGIN_SPP_REV_ID: cbbdc0cc3de09d237786967431114a9c40099b66
Replace fixed sleep_for waits with deterministic WaitForSocketFile()
that polls for the socket file to appear, confirming bind() completed.
Fixed sleeps (40-100ms) were insufficient under TCG emulation.

GIT_ORIGIN_SPP_REV_ID: 771fed81f52bd6fde7609714ba70c0a3db666c44
- queries the global backend table instead of using
preprocessor-based type dispatch.

GIT_ORIGIN_SPP_REV_ID: 48b49e71e1e0fda6b466434984419c3b2140208d
GIT_ORIGIN_SPP_REV_ID: b6e38f49d5b4649cc7999edfc0424885137c6d80
GIT_ORIGIN_SPP_REV_ID: 103a67c18ba94ee52cb7eff7cbe1fcada56a1833
GIT_ORIGIN_SPP_REV_ID: 4c4e808ff461c3a56913a04ead3204da2dc3789e
- provides minimal target called "console" that includes
the frontend, console backend and registry_aware_recorder_factory
that can be extended later by binaries to provide additional
backend targets.
- Existing lib targets that use frontend only will require
a transition step for binaries hence backend_console is provided
in addition

GIT_ORIGIN_SPP_REV_ID: ecb65c4d0bdfb452c863a19ee5ebefc3abc33ee1
- so that its made available in baselibs
for the registry_aware_recorder_factory
- Fixes mw/log targets such that the minimal
log target includes only frontend + empty backend
- Introduce minimal console log target with
frontend + console only backend
- All backends register console backend by default and
gracefully fallback to stub in case of failures

GIT_ORIGIN_SPP_REV_ID: 51dc3c071b6ca8c58f20450849db63c5c41e384b
GIT_ORIGIN_SPP_REV_ID: 58752d9f5d8e57052959caaf0556daae71b15f8d
GIT_ORIGIN_SPP_REV_ID: ec45e99a5b8f577efd79d7d1fbd35ad1729af5e7
GIT_ORIGIN_SPP_REV_ID: e64d1171a0ecce6ffc6bcefd0a1633c05e104ea6
GIT_ORIGIN_SPP_REV_ID: c6a518b8b4ad33c581705c595f34e6bef00ca787
GIT_ORIGIN_SPP_REV_ID: 2f98713a47ce9391add94cc4a8e53468da2598ee
GIT_ORIGIN_SPP_REV_ID: b043c154f33fe82a26ab4b64380fd68ae790a65d
GIT_ORIGIN_SPP_REV_ID: 82b782b3df6597e68819a7b3eb8c96aa726a4e6a
Pawel Pyszko and others added 17 commits April 29, 2026 07:15
GIT_ORIGIN_SPP_REV_ID: dfc30f98abf3f9d69ecf92cb23bf8a9ca441789c
GIT_ORIGIN_SPP_REV_ID: 4155aa92f76cdb79584080bd58d94d589d61fe6e
GIT_ORIGIN_SPP_REV_ID: b7c90782054a6bf63b75aaa07b93fc73c87a4618
GIT_ORIGIN_SPP_REV_ID: a16081c12c2e2c732030f62ef001b6a70ef7aebf
GIT_ORIGIN_SPP_REV_ID: c83b16ac45ff566817a982ef0705be65b32e1310
GIT_ORIGIN_SPP_REV_ID: aa5ee8452af9495843081dbb87a5ea33f4bf841b
Update Line coverage for aas/mw/log

GIT_ORIGIN_SPP_REV_ID: 85af0866e8f7f0371fe33657ebf09f79b8b47473
GIT_ORIGIN_SPP_REV_ID: 128b5082e574b9e97072cadec1380e995d54d3e5
GIT_ORIGIN_SPP_REV_ID: e0b7ad4970fd2c429b3f24fb0106d2f9f8539fd7
GIT_ORIGIN_SPP_REV_ID: 50e09c454781c4d1ac09ef22fa6e890c021ca579
GIT_ORIGIN_SPP_REV_ID: 8d41a4d7033c4e5ca42d3341335e935064b3d6b2
- backend related diagrams moved to respective
design docs directory.

GIT_ORIGIN_SPP_REV_ID: d9919cdb62618a54b5165b4226aa2f0cb993f7ac
- Adds console_logging sequence in top-level since
its default.
- Moves remote verbose_logging sequence to datarouter
backend design

GIT_ORIGIN_SPP_REV_ID: cbab224559081a60940cff75a4dd244f0a5bc4c4
GIT_ORIGIN_SPP_REV_ID: 323217f4c4b79ad6d86a89d0da1eaa39f26ec46e
- mw/log/design/README.md: point to new console logging and
  default recorders diagrams
- backend/datarouter_backend/README.md: fix paths to
  backend/datarouter_backend/ directory
- backend/file_output_backend.md: fix path to backend/

GIT_ORIGIN_SPP_REV_ID: 00557233d5a1fb34076be86c71b8cc15684599dd
GIT_ORIGIN_SPP_REV_ID: 38f1f6741d319f44cd602808f9682dcecbf1c9d4
- Update score_baselibs commit to latest main (e87426c8)
- Update score_communication commit to latest main (bc1e3c54)
- Replace backend_table with minimal target in backend BUILD
  (backend_table visibility restricted to baselibs subpackages)
- Replace recorder_factory with console target in score_log_bridge BUILD
- Replace recorder_factory with console target in score_log_bridge_cpp_init BUILD
@github-actions
Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: f5afab08-d9f6-48a1-b360-c9289b515fd6
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.9.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.17 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@2.3.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_tooling', the root module requires module version score_tooling@1.1.2, but got score_tooling@1.2.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_crates', the root module requires module version score_crates@0.0.6, but got score_crates@0.0.9 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rapidjson', the root module requires module version rapidjson@1.1.0, but got rapidjson@1.1.0.bcr.20241007 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 8.921s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@rmaddikery rmaddikery closed this Apr 29, 2026
@Y-Vaishnavi Y-Vaishnavi deleted the 7CECE363F0EE64EE11A5B7EC828632DD_2 branch April 29, 2026 05:22
@github-actions
Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants