Updates CODEOWNERS for datarouter and mw/log directories#29
Merged
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
d9fea1a to
87d8389
Compare
pawelrutkaq
requested changes
Jan 20, 2026
| score/mw/log/BUILD @rmaddikery @hoppe-and-dreams @mobileinfo @andreapefe @RSingh1511 @Y-Vaishnavi | ||
|
|
||
| # mw/log rust mw_logger owners | ||
| score/mw/log/rust/mw_logger @pawelrutkaq @arkjedrz |
Contributor
Author
There was a problem hiding this comment.
Sorry, align with folder that is not in main? Can't that be updated when that PR is brought in?
| # default owners | ||
| * @antonkri @rmaddikery @hoppe-and-dreams @mobileinfo @andreapefe @RSingh1511 @Y-Vaishnavi @pawelrutkaq @arkjedrz @arsibo | ||
| * @antonkri @pawelrutkaq @arkjedrz @arsibo | ||
|
|
Contributor
There was a problem hiding this comment.
all of this is probable as simple as
# Datarouter owners
/score/datarouter/ @rmaddikery @hoppe-and-dreams @mobileinfo @andreapefe @RSingh1511 @Y-Vaishnavi
# mw/log owners - all paths except rust/mw_logger
/score/mw/log/ @rmaddikery @hoppe-and-dreams @mobileinfo @andreapefe @RSingh1511 @Y-Vaishnavi
# mw/log rust mw_logger owners (more specific rule overrides general rule above)
/score/mw/log/rust/mw_logger/ @pawelrutkaq @arkjedrz
isnt it ?
Contributor
Author
There was a problem hiding this comment.
yes that's fine too. I am a fan of being explicit, but with a comment like you suggested should suffice. Thanks
87d8389 to
ecf1f62
Compare
ecf1f62 to
ca3faa7
Compare
- Assign codeowners to directories based on initial contributions
ca3faa7 to
d0dda45
Compare
pawelrutkaq
approved these changes
Jan 22, 2026
Contributor
pawelrutkaq
left a comment
There was a problem hiding this comment.
LGTM - it shall work with codeowners without write right, but to be sure, we will see.
rmaddikery
added a commit
to rmaddikery/logging
that referenced
this pull request
Feb 3, 2026
…re#29) - Assign codeowners to directories based on initial contributions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #