Skip to content

process: improve process description safety analysis#54

Merged
masc2023 merged 21 commits into
eclipse-score:mainfrom
qorix-group:vohae_safety_analysis
Jul 30, 2025
Merged

process: improve process description safety analysis#54
masc2023 merged 21 commits into
eclipse-score:mainfrom
qorix-group:vohae_safety_analysis

Conversation

@PandaeDo
Copy link
Copy Markdown
Contributor

Ref: Closes #5

@PandaeDo
Copy link
Copy Markdown
Contributor Author

PandaeDo commented Jun 30, 2025

PR shall close improvements from:
#49
#48

@github-actions
Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Comment thread process/process_areas/safety_analysis/_assets/safety_analysis_workflow.drawio.svg Outdated
@PandaeDo PandaeDo marked this pull request as draft June 30, 2025 13:45
Copy link
Copy Markdown
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments from my side.

Comment thread process/process_areas/safety_analysis/guidance/dfa_templates.rst
Comment thread process/process_areas/safety_analysis/guidance/index.rst
Comment thread process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst Outdated
Comment thread process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst Outdated
Copy link
Copy Markdown
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side now. 👍

@PandaeDo PandaeDo dismissed MaximilianSoerenPollak’s stale review July 3, 2025 12:54

The merge-base changed after approval.

@PandaeDo PandaeDo dismissed MaximilianSoerenPollak’s stale review July 3, 2025 14:16

The merge-base changed after approval.

@PandaeDo PandaeDo dismissed MaximilianSoerenPollak’s stale review July 4, 2025 07:07

The merge-base changed after approval.

@MaximilianSoerenPollak
Copy link
Copy Markdown
Contributor

Is this ready for review?

@PandaeDo PandaeDo marked this pull request as ready for review July 8, 2025 16:05
@PandaeDo PandaeDo requested a review from aschemmel-tech July 8, 2025 16:05
Copy link
Copy Markdown
Contributor

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR contains changes from other, already merged PRs

@MaximilianSoerenPollak
Copy link
Copy Markdown
Contributor

If you upgrade docs-as-code 0.4.2 it should contain the fixes & needs you need in order to hopefully past the tests here.

Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs discussion and typo fixes

Comment thread process/folder_templates/features/feature_name/safety_analysis/dfa.rst Outdated
Comment thread process/process_areas/safety_analysis/guidance/dfa_failure_initiators.rst Outdated
Comment thread process/process_areas/safety_analysis/guidance/dfa_failure_initiators.rst Outdated
Comment thread process/process_areas/safety_analysis/safety_analysis_concept.rst Outdated
Comment thread process/process_areas/safety_analysis/safety_analysis_concept.rst Outdated
Comment thread process/process_areas/safety_analysis/safety_analysis_concept.rst Outdated
Comment thread process/process_areas/safety_analysis/safety_analysis_concept.rst Outdated
Comment thread process/process_areas/safety_analysis/safety_analysis_concept.rst Outdated
@PandaeDo PandaeDo force-pushed the vohae_safety_analysis branch from 9200b6d to 40a7873 Compare July 10, 2025 13:23
Comment thread process/process_areas/safety_analysis/safety_analysis_workproducts.rst Outdated
Comment thread process/process_areas/safety_analysis/safety_analysis_workflow.rst Outdated
Comment thread process/process_areas/safety_analysis/safety_analysis_getstrt.rst Outdated
Comment thread process/process_areas/safety_analysis/safety_analysis_getstrt.rst Outdated
Copy link
Copy Markdown
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Comment thread process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst Outdated
Comment thread process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst Outdated
Comment thread process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst Outdated
Comment thread process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst Outdated
Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

Comment thread process/process_areas/safety_analysis/safety_analysis_roles.rst Outdated
Comment thread process/process_areas/safety_analysis/safety_analysis_getstrt.rst Outdated
Comment thread process/process_areas/safety_analysis/safety_analysis_getstrt.rst Outdated
Comment thread process/process_areas/safety_analysis/safety_analysis_concept.rst Outdated
Comment thread process/process_areas/safety_analysis/safety_analysis_concept.rst Outdated
Comment thread process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst Outdated
Comment thread process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst Outdated
Comment thread process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst Outdated
Comment thread process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst Outdated
Comment thread process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst Outdated
@PandaeDo PandaeDo force-pushed the vohae_safety_analysis branch 2 times, most recently from 61d8441 to 63480a5 Compare July 29, 2025 16:22
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect this file in a parallel folder, platform, but we can that also take in a future PR

Copy link
Copy Markdown
Contributor

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for now, further improvements as defined in #68

Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates sufficient to merge

@masc2023 masc2023 merged commit c6d89e7 into eclipse-score:main Jul 30, 2025
5 checks passed
@PandaeDo PandaeDo mentioned this pull request Nov 5, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants