Skip to content

Commit 6324792

Browse files
committed
addressing copilot review comments
1 parent bc325c9 commit 6324792

4 files changed

Lines changed: 397 additions & 63 deletions

File tree

feature_integration_tests/README_FIT_LIFECYCLE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ The lifecycle FIT tests partially verify the following requirements:
3232

3333
**Graceful Degradation**:
3434
The tests are designed to run in environments without the Launch Manager daemon. When the daemon is not available:
35-
- Lifecycle client calls return `false` (C++) or `false` (Rust) instead of panicking
35+
- Lifecycle client calls return an empty result (C++) or `false` (Rust) instead of panicking
3636
- Tests log informational messages explaining the demonstration nature
3737
- Tests still validate API signatures and integration patterns
3838
- Tests pass successfully, confirming proper integration code

feature_integration_tests/test_cases/tests/lifecycle/test_process_termination.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
partially_verifies=[
3434
"feat_req__lifecycle__configurable_timeout",
3535
"feat_req__lifecycle__process_termination",
36-
"feat_req__lifecycle__terminationn_dependency",
36+
"feat_req__lifecycle__termination_dependency",
3737
"feat_req__lifecycle__time_to_wait_config",
3838
"feat_req__lifecycle__launch_manager_shutdown",
3939
"feat_req__lifecycle__slow_shutdown_support",

0 commit comments

Comments
 (0)