Cleanup based on missed review from #101

Author: pawelrutkaq

scripts/known_good/models/module.py

@@ -106,6 +106,7 @@ def from_dict(cls, name: str, module_data: Dict[str, Any]) -> Module:
         metadata_data = module_data.get("metadata")
         if metadata_data is not None:
             metadata = Metadata.from_dict(metadata_data)
+            # Enable once we are able to remove '*' in known_good.json
             # if any("*" in target for target in metadata.exclude_test_targets):
             #     raise Exception(
             #         f"Module {name} has wildcard '*' in exclude_test_targets, which is not allowed. "

scripts/known_good/update_module_from_known_good.py

@@ -6,9 +6,9 @@
 Usage:
   python3 scripts/known_good/update_module_from_known_good.py \
       --known known_good.json \
-      --output score_modules.MODULE.bazel
+      --output-dir bazel_common
 
-The generated score_modules.MODULE.bazel file is included by MODULE.bazel.
+The generated score_modules_NAME_.MODULE.bazel file is included by MODULE.bazel.
 
 Note: To override repository commits before generating the MODULE.bazel file,
 use scripts/known_good/override_known_good_repo.py first to create an updated known_good.json.

scripts/quality_runners.py

@@ -72,8 +72,6 @@ def cpp_coverage(module: Module, artifact_dir: Path) -> ProcessResult:
         "genhtml",
         f"{bazel_coverage_output_directory}/_coverage/_coverage_report.dat",
         f"--output-directory={output_dir}",
-        # f"--source-directory={bazel_source_directory}",
-        # "--synthesize-missing",
         "--show-details",
         "--legend",
         "--function-coverage",