From 5e2cd48a302937d33ccc2b178cce72d2b0b97deb Mon Sep 17 00:00:00 2001 From: Giorgos Gaganis Date: Fri, 26 Jun 2026 10:38:21 +0200 Subject: [PATCH] Use endHandler in NetTest.testListenDomainSocketAddress This test is flaky and fails in CI builds(3/40 failed builds up to 25/6/2026). endHandler appears as a more appropriate function to ensure that all of the socket data are consumed becuase of two reasons: * It is used by io.vertx.core.streams.ReadStream#collect to read an entire read stream and also * The documentation of endHandler mentions the following "This handler might be called after the close handler when the socket is paused and there are still buffers to deliver." While in the test we do not have a clear pause event happening but it suggests that closeEvent might be called before all buffers have been delivered. --- vertx-core/src/test/java/io/vertx/tests/net/NetTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vertx-core/src/test/java/io/vertx/tests/net/NetTest.java b/vertx-core/src/test/java/io/vertx/tests/net/NetTest.java index b805fe23f8e..b1ba0561e75 100755 --- a/vertx-core/src/test/java/io/vertx/tests/net/NetTest.java +++ b/vertx-core/src/test/java/io/vertx/tests/net/NetTest.java @@ -2209,8 +2209,8 @@ private void testListenDomainSocketAddress(Checkpoint checkpoint, VertxInternal .onComplete(onSuccess(so -> { Buffer received = Buffer.buffer(); so.handler(received::appendBuffer); - so.closeHandler(v -> { - assertEquals(received.toString(), sockAddress.path()); + so.endHandler(v -> { + assertEquals(sockAddress.path(), received.toString()); latch.countDown(); }); }));