From 965e735b332af0075d97619a4295b6d490b7d536 Mon Sep 17 00:00:00 2001
From: Howard Liu <16122634+hlhowardliu@users.noreply.github.com>
Date: Sat, 24 Mar 2018 03:09:29 -0400
Subject: [PATCH] Update method stored in "call" for recombineSL and
 recombineCVSL

The new method set for recombineCVSL was not being passed to the "call" object, which caused the risks to be calculated incorrectly when the new CV SL object was passed to summary.CV.SuperLearner. The edits to recombineCVSL fixes this.

Risks were calculated correctly for new SL objects created from recombineSL, and the edits to recombineSL only update the call object to reflect the new method used.
---
 R/recombine.R | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/R/recombine.R b/R/recombine.R
index 3c41812..38cc2e3 100644
--- a/R/recombine.R
+++ b/R/recombine.R
@@ -13,6 +13,7 @@ recombineSL <- function(object, Y, method = "method.NNloglik", verbose = FALSE)
     stop("The supplied 'object' is not of class, SuperLearner.")
   }
   
+  newMethod <- method
   if (is.character(method)) {
     if (exists(method, mode = 'list')) {
       method <- get(method, mode = 'list')
@@ -35,6 +36,7 @@ recombineSL <- function(object, Y, method = "method.NNloglik", verbose = FALSE)
   
   # get relevant objects from the SuperLearner fit object
   call <- object$call
+  call[["method"]] <- newMethod
   obsWeights <- object$obsWeights
   control <- object$control
   cvControl <- object$cvControl
@@ -129,6 +131,8 @@ recombineCVSL <- function(object, method = "method.NNloglik", verbose = FALSE, s
   if (!inherits(object, "CV.SuperLearner")) {
     stop("The supplied 'object' is not of class, CV.SuperLearner.")
   }
+  
+  newMethod <- method
   if (is.character(method)) {
     if (exists(method, mode = 'list')) {
       method <- get(method, mode = 'list')
@@ -151,6 +155,7 @@ recombineCVSL <- function(object, method = "method.NNloglik", verbose = FALSE, s
   
   # get relevant objects from the CV.SuperLearner object
   call <- object$call
+  call[["method"]] <- newMethod         
   library <- object$SL.library
   libraryNames <- object$libraryNames
   folds <- object$folds
@@ -222,4 +227,4 @@ recombineCVSL <- function(object, method = "method.NNloglik", verbose = FALSE, s
               Y = Y)
   class(out) <- "CV.SuperLearner"
   return(out)
-}
\ No newline at end of file
+}