Added support for rendering IEnumerable entities#80
Open
AbdoMahfoz wants to merge 1 commit intoedandersen:masterfrom
Open
Added support for rendering IEnumerable entities#80AbdoMahfoz wants to merge 1 commit intoedandersen:masterfrom
AbdoMahfoz wants to merge 1 commit intoedandersen:masterfrom
Conversation
rezabashiri
reviewed
Sep 3, 2023
| { | ||
| foreach (var raw in (IEnumerable)entityProperty.GetValue(value)!) | ||
| { | ||
| finalString += $"<li><a href=\"{Url.Action("Index", new { id = raw.GetType().Name })}\">{raw}</a></li>"; |
There was a problem hiding this comment.
strings behave like value variables and each time you add to them create another variable and its not optimum, better to use stringbuilder
Plotron
reviewed
Dec 11, 2023
| finalString += $"<li><a href=\"{Url.Action("Index", new { id = raw.GetType().Name })}\">{raw}</a></li>"; | ||
| } | ||
| } | ||
| catch(NullReferenceException) {} |
There was a problem hiding this comment.
What's up with that? Consuming exceptions like that is an anti-pattern. Shouldn't there be a way to avoid an NRE in the first place?
|
When this changes will be realesed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the following case
Currently, navigation properties
ChildrenandProductscause the code to crash.After inspecting the code I found that there is no support for rendering such properties.
So, I made the controller eager load the entities before sending them to the View to avoid the crash, then I added code in the view that should render these properties as
<ul>