From dae5cd112851d2393c171729ad3589c760d7704d Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 9 Oct 2026 01:34:06 +0000 Subject: [PATCH 1/2] chore(deps): bump rust-toolchain Bumps the patch-minor group with 1 update: [rust-toolchain](https://github.com/rust-lang/rust). Updates `rust-toolchain` from 1.98.1 to 1.99.0 - [Release notes](https://github.com/rust-lang/rust/releases) - [Changelog](https://github.com/rust-lang/rust/blob/main/RELEASES.md) - [Commits](https://github.com/rust-lang/rust/compare/1.98.1...1.99.0) --- updated-dependencies: - dependency-name: rust-toolchain dependency-version: 1.99.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patch-minor ... Signed-off-by: dependabot[bot] --- rust-toolchain.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust-toolchain.toml b/rust-toolchain.toml index e630049..eb39547 100644 --- a/rust-toolchain.toml +++ b/rust-toolchain.toml @@ -1,4 +1,4 @@ [toolchain] -channel = "1.98.1" +channel = "1.99.0" profile = "minimal" components = ["clippy", "rustfmt"] From 474187efef515090d935a1fcd4b02f9e799289fe Mon Sep 17 00:00:00 2001 From: edbfi <326875205+edbfi@users.noreply.github.com> Date: Mon, 12 Oct 2026 01:46:25 +0200 Subject: [PATCH 2/2] fix(clippy): satisfy Rust 1.99 lints assert_is_empty now covers negated assert!(!x.is_empty()) without a message, and float_cmp no longer fires on the memory tests' exact assert_eq!, which left their #[expect] attributes unfulfilled. Signed-off-by: edbfi <326875205+edbfi@users.noreply.github.com> --- src/config/models.rs | 6 +++--- src/utils/icon_extractor.rs | 2 +- tests/memory_usage_test.rs | 22 +++++----------------- 3 files changed, 9 insertions(+), 21 deletions(-) diff --git a/src/config/models.rs b/src/config/models.rs index 3a36945..3b62fc9 100644 --- a/src/config/models.rs +++ b/src/config/models.rs @@ -1109,7 +1109,7 @@ mod tests { assert_eq!(app.process_name, expected_process_name); assert_eq!(app.exe_path, current_exe); assert!(app.enabled); // Should default to enabled - assert!(!app.display_name.is_empty()); // Should have a display name + assert_ne!(app.display_name, ""); // Should have a display name } #[test] @@ -1267,8 +1267,8 @@ mod tests { let app = result.unwrap(); // Should have basic metadata - assert!(!app.display_name.is_empty()); - assert!(!app.process_name.is_empty()); + assert_ne!(app.display_name, ""); + assert_ne!(app.process_name, ""); assert_eq!(app.exe_path, current_exe); } diff --git a/src/utils/icon_extractor.rs b/src/utils/icon_extractor.rs index d413494..812ea16 100644 --- a/src/utils/icon_extractor.rs +++ b/src/utils/icon_extractor.rs @@ -557,7 +557,7 @@ mod tests { let result = extract_display_name_from_exe(&path); assert!(result.is_ok()); let name = result.unwrap(); - assert!(!name.is_empty()); + assert_ne!(name, ""); } #[test] diff --git a/tests/memory_usage_test.rs b/tests/memory_usage_test.rs index 8568ec2..4b619b8 100644 --- a/tests/memory_usage_test.rs +++ b/tests/memory_usage_test.rs @@ -125,15 +125,9 @@ fn test_memory_stats_within_limits() { }; assert!(stats.is_within_limits()); - // Allow exact float comparison: values are constructed to be exact multiples - #[expect( - clippy::float_cmp, - reason = "Values are constructed as exact multiples of 1024*1024, so float comparison is precise" - )] - { - assert_eq!(stats.total_mb(), 40.0); - assert_eq!(stats.icon_cache_mb(), 5.0); - } + // Exact float comparison is precise: values are exact multiples of 1024*1024 + assert_eq!(stats.total_mb(), 40.0); + assert_eq!(stats.icon_cache_mb(), 5.0); } #[test] @@ -148,14 +142,8 @@ fn test_memory_stats_exceeds_limits() { }; assert!(!stats.is_within_limits()); - // Allow exact float comparison: value is constructed to be exact multiple - #[expect( - clippy::float_cmp, - reason = "Value is constructed as exact multiple of 1024*1024, so float comparison is precise" - )] - { - assert_eq!(stats.total_mb(), 60.0); - } + // Exact float comparison is precise: the value is an exact multiple of 1024*1024 + assert_eq!(stats.total_mb(), 60.0); } #[test]