ci: Split the Firefox 94 browser test into its own job, as Browserstack often times out with it

Author: eemeli

.github/vitest.browserstack.config.js

@@ -13,6 +13,14 @@ const bsDefaults = {
   'browserstack.accessKey': env.BROWSERSTACK_ACCESS_KEY || env.BROWSERSTACK_KEY
 }
 
+// e.g. BROWSERS="chrome:93 chrome:latest firefox:94 firefox:latest"
+const instances = env.BROWSERS.split(' ').map(name => {
+  let [browser, browser_version] = name.split(':')
+  if (browser !== 'chrome') browser = `playwright-${browser}`
+  const provider = bsProvider({ browser, browser_version })
+  return { name, browser: 'chromium', provider }
+})
+
 const bsProvider = opts =>
   playwright({
     connectOptions: {
@@ -38,34 +46,7 @@ export default defineConfig({
       enabled: true,
       provider: playwright(),
       connectTimeout: 300_000,
-      instances: [
-        {
-          name: 'Chrome Old',
-          browser: 'chromium',
-          provider: bsProvider({ browser: 'chrome', browser_version: '93' })
-        },
-        {
-          name: 'Chrome New',
-          browser: 'chromium',
-          provider: bsProvider({ browser: 'chrome', browser_version: 'latest' })
-        },
-        {
-          name: 'Firefox Old',
-          browser: 'chromium',
-          provider: bsProvider({
-            browser: 'playwright-firefox',
-            browser_version: '94'
-          })
-        },
-        {
-          name: 'Firefox New',
-          browser: 'chromium',
-          provider: bsProvider({
-            browser: 'playwright-firefox',
-            browser_version: 'latest'
-          })
-        }
-      ]
+      instances
     },
     globals: true,
     include: ['tests/**/*.{js,ts}'],

.github/workflows/browsers.yml

@@ -28,6 +28,37 @@ jobs:
       - run: npm run build
       - run: npm install --no-save @vitest/browser-playwright@4
       - run: npx vitest run --config=.github/vitest.browserstack.config.js
+        env:
+          BROWSERS: chrome:93 chrome:latest firefox:latest
+
+      - uses: browserstack/github-actions/setup-local@master
+        if: always()
+        with:
+          local-testing: stop
+
+  legacy:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v6
+        with: { submodules: true }
+      - uses: actions/setup-node@v6
+      - uses: browserstack/github-actions/setup-env@master
+        with:
+          username:  ${{ secrets.BROWSERSTACK_USERNAME }}
+          access-key: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
+          project-name: yaml
+      - uses: browserstack/github-actions/setup-local@master
+        with:
+          local-testing: start
+          local-identifier: random
+
+      - run: npm ci
+      - run: npm run build
+      - run: npm install --no-save @vitest/browser-playwright@4
+      - run: npx vitest run --config=.github/vitest.browserstack.config.js
+        env:
+          BROWSERS: firefox:94
 
       - uses: browserstack/github-actions/setup-local@master
         if: always()