Skip to content

Error on canary: {{#with}} is deprecated #45

@gitKrystan

Description

@gitKrystan

Hello there!

We are running into this deprecation on our canary builds:

Template Compiler Error (broccoli-persistent-filter:TemplateCompiler) in ember-elsewhere/templates/components/from-elsewhere.hbs

`{{#with}}` is deprecated. If you always want the block to render, replace `{{#with}}` with `{{#let}}`. If you want to conditionally render the block, use `{{#let}}` together with `{{#if}} instead. ('ember-elsewhere/templates/components/from-elsewhere.hbs' @ L6:C6) 

Looks like it comes from this template:

{{#with active.lastObject.component as |c|}}
{{component c}}
{{/with}}

Happy to make a PR if you'd like. I don't know enough about ember-elsewhere to know if I should make the block render conditionally or if just replacing {{#with}} with {{#let}} would be appropriate. Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions