Skip to content

Do not create a proposal.pay entry when the amount in 0 #185

Description

@jeisses

If a proposal does not have a reward, it should not create a pay entry in the blockchain.
This is wasted RAM and also introduced a bug that the proposal can note be executed because the amount is not positive.
This bug has been fixed on the smart contract side; however for clarity and efficiency we should still not add 0-pay reward entries

Steps

  • On proposal create and proposal edit, check if the reward is 0. In this case, submit an empty array in the proposal.pay field.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions