Skip to content

Useless fields defined in Elsa.Persistence.Dapper.Migrations #133

@heku

Description

@heku

Looks like the following fields defined in Elsa.Persistence.Dapper.Migrations for WorkflowExecutionLogRecords table are useless. (may a copy-paste issue)

// elsa-extensions\src\modules\persistence\Elsa.Persistence.Dapper.Migrations\Runtime\Initial.cs
    IfDatabase("SqlServer", "Oracle", "MySql", "Postgres")
        .Create
        .Table("WorkflowExecutionLogRecords")
        .WithColumn("Id").AsString().PrimaryKey()
        .WithColumn("WorkflowDefinitionId").AsString().NotNullable().Indexed()
        .WithColumn("WorkflowDefinitionVersionId").AsString().NotNullable().Indexed()
        .WithColumn("WorkflowInstanceId").AsString().NotNullable().Indexed()
        .WithColumn("WorkflowVersion").AsInt32().NotNullable().Indexed()
        .WithColumn("ActivityInstanceId").AsString().NotNullable().Indexed()
        .WithColumn("ParentActivityInstanceId").AsString().Nullable().Indexed()
        .WithColumn("ActivityId").AsString().NotNullable().Indexed()
        .WithColumn("ActivityType").AsString().NotNullable().Indexed()
        .WithColumn("ActivityTypeVersion").AsInt32().NotNullable().Indexed()
        .WithColumn("ActivityName").AsString().Nullable().Indexed()
        .WithColumn("ActivityNodeId").AsString(MaxNodeIdColumnLength).NotNullable().Indexed()
        .WithColumn("EventName").AsString().Nullable().Indexed()
        .WithColumn("Message").AsString(MaxValue).Nullable()
        .WithColumn("Source").AsString().Nullable()
        .WithColumn("SerializedActivityState").AsString(MaxValue).Nullable()
        .WithColumn("SerializedPayload").AsString(MaxValue).Nullable()
        .WithColumn("SerializedException").AsString(MaxValue).Nullable()  //   <----------- useless field
        .WithColumn("Timestamp").AsDateTimeOffset().NotNullable().Indexed()
        .WithColumn("Sequence").AsInt64().NotNullable().Indexed()
        ;

    IfDatabase("Sqlite")
        .Create
        .Table("WorkflowExecutionLogRecords")
        .WithColumn("Id").AsString().PrimaryKey()
        .WithColumn("WorkflowDefinitionId").AsString().NotNullable().Indexed()
        .WithColumn("WorkflowDefinitionVersionId").AsString().NotNullable().Indexed()
        .WithColumn("WorkflowInstanceId").AsString().NotNullable().Indexed()
        .WithColumn("WorkflowVersion").AsInt32().NotNullable().Indexed()
        .WithColumn("ActivityInstanceId").AsString().NotNullable().Indexed()
        .WithColumn("ParentActivityInstanceId").AsString().Nullable().Indexed()
        .WithColumn("ActivityId").AsString().NotNullable().Indexed()
        .WithColumn("ActivityType").AsString().NotNullable().Indexed()
        .WithColumn("ActivityTypeVersion").AsInt32().NotNullable().Indexed()
        .WithColumn("ActivityName").AsString().Nullable().Indexed()
        .WithColumn("ActivityNodeId").AsString(MaxNodeIdColumnLength).NotNullable().Indexed()
        .WithColumn("EventName").AsString().Nullable().Indexed()
        .WithColumn("Message").AsString(MaxValue).Nullable()
        .WithColumn("Source").AsString().Nullable()
        .WithColumn("SerializedActivityState").AsString(MaxValue).Nullable()
        .WithColumn("SerializedPayload").AsString(MaxValue).Nullable()
        .WithColumn("SerializedOutputs").AsString(MaxValue).Nullable()    //   <----------- useless field
        .WithColumn("SerializedException").AsString(MaxValue).Nullable()  //   <----------- useless field
        .WithColumn("Timestamp").AsDateTime2().NotNullable().Indexed()
        .WithColumn("Sequence").AsInt64().NotNullable().Indexed()
        ;

https://github.com/elsa-workflows/elsa-extensions/blob/main/src/modules/persistence/Elsa.Persistence.Dapper.Migrations/Runtime/Initial.cs#L72
https://github.com/elsa-workflows/elsa-extensions/blob/main/src/modules/persistence/Elsa.Persistence.Dapper.Migrations/Runtime/Initial.cs#L97-L98

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions