UX: It is now very easy to accidentily "mark all as read"

[Bargraph6]

Context

• In 40f64ea the elfeed search mode map was changed to use :parent special-mode-map
  • This maps 0-9 directly to prefix argument (i.e. hitting C- not required)
• In b3e260e a change was made so that a prefix argument cause all entries in the search view to be untagged
  • by default, this is mapped to r, which is near the number row

The issue

These two changes interact in a way where it is very easy to accidentally mark all entries as "read" by accidentally grazing a digit key when hitting r

There is no message to explain what happened, or a straightforward way to undo an accidental mark-all.

The request

• If binding 0-9 directly to prefix arguments is desired, then please consider not introducing destructive actions that are triggered by prefix arguments
  • or at least not enabled by default
• if the binding of 0-9 was just an unintended side-effect of using special-mode-map, then please unbind them by default so a C- is needed.

[minad]

Converted to discussion. I see your point but hitting digits together with r should not be that likely. I prefer if we stick to the special mode map as is, for consistency with other modes. However it may make sense to add a confirmation option for operations on multiple entries.

[aavanian]

How I guard it for the time being:

(defun 151e/elfeed-search-confirm-bulk-tag (&rest _)
  "Confirm a tag operation that a prefix argument widened to every entry.

`elfeed-search--tag' treats any non-nil `current-prefix-arg' as a request
to act on all of `elfeed-search-entries' (everything matching the current
filter) instead of the point/region/marked selection.  Since
`special-mode-map' binds bare digits to prefix arguments, a stray digit
next to `r' silently untags `unread' across the whole buffer with no undo.
Require confirmation, showing the count, before any such bulk operation."
  (when (and current-prefix-arg
             (not (yes-or-no-p
                   (format "Apply tag change to all %d entries matching this filter? "
                           (length elfeed-search-entries)))))
    (user-error "Cancelled bulk elfeed tag operation")))

(advice-add 'elfeed-search--tag :before #'151e/elfeed-search-confirm-bulk-tag)

[Bargraph6]

@aavanian nice! that's a much more legit fix than what I originally did 😅

    (keymap-set elfeed-search-mode-map "3" 'self-insert-command)
    (keymap-set elfeed-search-mode-map "4" 'self-insert-command)
    (keymap-set elfeed-search-mode-map "5" 'self-insert-command)

[minad]

I've added a new customization option in f35317b.

[Bargraph6]

@minad I just gave the setting a try and it works great. Thank you!