compilation failure, incompatible pointer types

[olagarde]

Compile fails on incompatible pointer type, void* != int*. Should wireview_remove() be void when wireview_probe is int, both are set identically for struct wireviewprobe, and neither are used anywhere else?

[olagarde@rocky temp]$ uname -a
Linux rocky 5.14.0-611.49.1.el9_7.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Apr 23 13:13:41 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux

[olagarde@rocky temp]$ make --version
GNU Make 4.3
Built for x86_64-redhat-linux-gnu
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

[olagarde@rocky temp]$ gcc --version
gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-11)
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[olagarde@rocky temp]$ rpm -q glibc
glibc-2.34-231.el9_7.10.x86_64
glibc-2.34-231.el9_7.10.i686

[olagarde@rocky temp]$ git clone https://github.com/emaspa/wireview-hwmon.git
Cloning into 'wireview-hwmon'...
remote: Enumerating objects: 138, done.
remote: Counting objects: 100% (138/138), done.
remote: Compressing objects: 100% (95/95), done.
remote: Total 138 (delta 86), reused 81 (delta 36), pack-reused 0 (from 0)
Receiving objects: 100% (138/138), 37.98 KiB | 9.49 MiB/s, done.
Resolving deltas: 100% (86/86), done.

[olagarde@rocky temp]$ cd wireview-hwmon/

[olagarde@rocky wireview-hwmon]$ ls -l
total 84
-rw-r-----. 1 olagarde olagarde 255 May 5 04:50 99-wireview-hwmon.rules
drwxr-----. 3 olagarde olagarde 4096 May 5 04:50 debian
-rw-r-----. 1 olagarde olagarde 345 May 5 04:50 dkms.conf
-rw-r-----. 1 olagarde olagarde 1301 May 5 04:50 Makefile
-rw-r-----. 1 olagarde olagarde 26 May 5 04:50 Makefile.dkms
-rw-r-----. 1 olagarde olagarde 8743 May 5 04:50 README.md
-rw-r-----. 1 olagarde olagarde 14541 May 5 04:50 wireviewctl.c
-rw-r-----. 1 olagarde olagarde 19970 May 5 04:50 wireviewd.c
-rw-r-----. 1 olagarde olagarde 198 May 5 04:50 wireviewd.service
-rw-r-----. 1 olagarde olagarde 12063 May 5 04:50 wireview_hwmon.c

[olagarde@rocky wireview-hwmon]$ make
make -C /lib/modules/5.14.0-611.49.1.el9_7.x86_64/build M=/home/olagarde/temp/wireview-hwmon modules
make[1]: Entering directory '/usr/src/kernels/5.14.0-611.49.1.el9_7.x86_64'
CC [M] /home/olagarde/temp/wireview-hwmon/wireview_hwmon.o
/home/olagarde/temp/wireview-hwmon/wireview_hwmon.c:436:19: error: initialization of ‘int (*)(struct platform_device )’ from incompatible pointer type ‘void ()(struct platform_device *)’ [-Werror=incompatible-pointer-types]
436 | .remove = wireview_remove,
| ^~~~~~~~~~~~~~~
/home/olagarde/temp/wireview-hwmon/wireview_hwmon.c:436:19: note: (near initialization for ‘wireview_driver.remove’)
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:249: /home/olagarde/temp/wireview-hwmon/wireview_hwmon.o] Error 1
make[1]: *** [Makefile:1953: /home/olagarde/temp/wireview-hwmon] Error 2
make[1]: Leaving directory '/usr/src/kernels/5.14.0-611.49.1.el9_7.x86_64'
make: *** [Makefile:9: module] Error 2