Skip to content

Image downloads, rewrite by continuousmining#14

Open
emcniece wants to merge 1 commit into
masterfrom
feat/image-download
Open

Image downloads, rewrite by continuousmining#14
emcniece wants to merge 1 commit into
masterfrom
feat/image-download

Conversation

@emcniece
Copy link
Copy Markdown
Owner

Code provided in #13

Untested - needs verification, and ideally unit tests!

@timbostop
Copy link
Copy Markdown

timbostop commented May 11, 2025

This does seem to work (unlike the master branch!)

There is a copy and paste error:

Line 22:

_LOGGER = logging.getLogger(name)

should be:

_LOGGER = logging.getLogger(__name__)

There's also a deprecation warning:

Logger: homeassistant.helpers.typing
Source: helpers/deprecation.py:222
First occurred: 08:14:07 (1 occurrence)
Last logged: 08:14:07

HomeAssistantType was used from ha_imap_attachment, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.HomeAssistant instead, please report it to the author of the 'ha_imap_attachment' custom integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants