Code Review #5
Description
Overview
In this file we will leave comments of the review process as bullet points marked with the below
states:
| Symbol | Meaning |
|---|---|
| I | Important |
| A | Attention |
| N | Nice to have |
It is only intended to display omissions or things we would do differently and/or general guidelines. It does not reflect the quality of your code as a hole so please don't receive it as all negative and despair :)
General
- I | App is not fully functional.Ex Transactions cannot be created
- I | Relations in model are incorrect. This lead to incorrect business logic at best or exceptions at worst. Ex Customers & Employes should have a list of transactions and not a single one (One-To-many relation)
- I | Many ommitions in repo classes
We did not continue the code review due to the severity of the aforementioned errors