split up the python bindings and fixed minor bug for gate label creation for empty gate lists

Simon Klix · Simon Klix · commit 677840c62ec9 · 2026-03-30T21:49:09.000+02:00
diff --git a/plugins/machine_learning/include/machine_learning/labels/subgraph_label.h b/plugins/machine_learning/include/machine_learning/labels/subgraph_label.h
@@ -44,7 +44,7 @@ namespace hal
                  * @param[in] ctx - The machine learning context.
                  * @returns A vector of label vectors for each pair on success, an error otherwise.
                  */
-                virtual Result<std::vector<std::vector<u32>>> calculate_labels(Context& ctx, const std::vector<Gate*>& subgraphs) const = 0;
+                virtual Result<std::vector<std::vector<u32>>> calculate_labels(Context& ctx, const std::vector<std::vector<Gate*>>& subgraphs) const = 0;
 
                 virtual std::string to_string() const = 0;
             };
@@ -74,7 +74,7 @@ namespace hal
                  * @param[in] ctx - The machine learning context.
                  * @returns A vector of label vectors for each pair on success, an error otherwise.
                  */
-                Result<std::vector<std::vector<u32>>> calculate_labels(Context& ctx, const std::vector<Gate*>& subgraphs) const override;
+                Result<std::vector<std::vector<u32>>> calculate_labels(Context& ctx, const std::vector<std::vector<Gate*>>& subgraphs) const override;
 
                 /**
                  * @brief Helper function to annotate contained components to a falttened subgraph of gates in front of a register by analyzing a unflattened twin netlist 
@@ -130,7 +130,7 @@ namespace hal
                     u32 label_size = m_key_words.size() + 1;
 
                     std::vector<u32> v(label_size, 0);
-                    for (const auto [m_idx, m_count] : matches)
+                    for (const auto& [m_idx, m_count] : matches)
                     {
                         if (m_idx >= m_key_words.size())
                         {
@@ -168,7 +168,7 @@ namespace hal
                  * @param[in] ctx - The machine learning context.
                  * @returns A vector of label vectors for each pair on success, an error otherwise.
                  */
-                Result<std::vector<std::vector<u32>>> calculate_labels(Context& ctx, const std::vector<Gate*>& subgraphs) const override;
+                Result<std::vector<std::vector<u32>>> calculate_labels(Context& ctx, const std::vector<std::vector<Gate*>>& subgraphs) const override;
 
                 /**
                  * @brief Helper function to annotate contained components to top module of netlöist by reading from netlist metadata at a path 
@@ -224,7 +224,7 @@ namespace hal
                     u32 label_size = m_key_words.size() + 1;
 
                     std::vector<u32> v(label_size, 0);
-                    for (const auto [m_idx, m_count] : matches)
+                    for (const auto& [m_idx, m_count] : matches)
                     {
                         if (m_idx >= m_key_words.size())
                         {
@@ -238,4 +238,4 @@ namespace hal
             };
         }    // namespace subgraph_label
     }    // namespace machine_learning
-}    // namespace hal
+}    // namespace hal
diff --git a/plugins/machine_learning/python/bindings/edge_feature.cpp b/plugins/machine_learning/python/bindings/edge_feature.cpp
@@ -8,6 +8,8 @@ namespace hal
         {
             void bind_edge_features(py::module& m, py::module& py_edge_feature)
             {
+        UNUSED(m);
+
         py::class_<machine_learning::edge_feature::EdgeFeature, RawPtrWrapper<machine_learning::edge_feature::EdgeFeature>> py_edge_feature_class(py_edge_feature,
                                                                                                                                                   "EdgeFeature",
                                                                                                                                                   R"(
diff --git a/plugins/machine_learning/python/bindings/gate_label.cpp b/plugins/machine_learning/python/bindings/gate_label.cpp
@@ -8,6 +8,8 @@ namespace hal
         {
             void bind_gate_labels(py::module& m, py::module& py_gate_label)
             {
+        UNUSED(m);
+
         py::class_<machine_learning::gate_label::GateLabel, std::shared_ptr<machine_learning::gate_label::GateLabel>> py_gate_label_class(py_gate_label, "GateLabel", R"(
             Base class for calculating labels for machine learning models.
 
diff --git a/plugins/machine_learning/python/bindings/gate_pair_feature.cpp b/plugins/machine_learning/python/bindings/gate_pair_feature.cpp
@@ -8,6 +8,8 @@ namespace hal
         {
             void bind_gate_pair_features(py::module& m, py::module& py_gate_pair_feature)
             {
+        UNUSED(m);
+
         // machine_learning::features::gate_pair_feature
         py::class_<machine_learning::gate_pair_feature::GatePairFeature, std::shared_ptr<machine_learning::gate_pair_feature::GatePairFeature>> py_gate_pair_feature_class(
             py_gate_pair_feature, "GatePairFeature", R"(
diff --git a/plugins/machine_learning/python/bindings/gate_pair_label.cpp b/plugins/machine_learning/python/bindings/gate_pair_label.cpp
@@ -8,6 +8,8 @@ namespace hal
         {
             void bind_gate_pair_labels(py::module& m, py::module& py_gate_pair_label)
             {
+        UNUSED(m);
+
         py::class_<machine_learning::gate_pair_label::GatePairLabel> py_gate_pair_label_class(py_gate_pair_label,
                                                                                               "GatePairLabel",
                                                                                               R"(
diff --git a/plugins/machine_learning/python/bindings/plugin.cpp b/plugins/machine_learning/python/bindings/plugin.cpp
@@ -1,12 +1,12 @@
-#include "bindings/register.h"
+#include "register.h"
 
 namespace hal
 {
     namespace machine_learning
     {
         namespace python
         {
-            void bind_core(py::module& m)
+            void bind_plugin(py::module& m)
             {
         py::class_<MachineLearningPlugin, RawPtrWrapper<MachineLearningPlugin>, BasePluginInterface> py_machine_learning_plugin(
             m, "MachineLearningPlugin", R"(Provides machine learning functionality as a plugin within the HAL framework.)");
diff --git a/plugins/machine_learning/python/bindings/register.h b/plugins/machine_learning/python/bindings/register.h
@@ -8,7 +8,7 @@ namespace hal
     {
         namespace python
         {
-            void bind_core(py::module& m);
+            void bind_plugin(py::module& m);
             void bind_gate_features(py::module& m, py::module& py_gate_feature);
             void bind_gate_pair_features(py::module& m, py::module& py_gate_pair_feature);
             void bind_gate_pair_labels(py::module& m, py::module& py_gate_pair_label);
diff --git a/plugins/machine_learning/python/bindings/subgraph_label.cpp b/plugins/machine_learning/python/bindings/subgraph_label.cpp
@@ -8,6 +8,8 @@ namespace hal
         {
             void bind_subgraph_labels(py::module& m, py::module& py_subgraph_label)
             {
+        UNUSED(m);
+
         py::class_<machine_learning::subgraph_label::SubgraphLabel, std::shared_ptr<machine_learning::subgraph_label::SubgraphLabel>> py_subgraph_label_class(py_subgraph_label, "SubgraphLabel", R"(
             Base class for calculating labels for machine learning models.
 
@@ -39,7 +41,7 @@ namespace hal
 
         py_subgraph_label_class.def(
             "calculate_labels",
-            [](const machine_learning::subgraph_label::SubgraphLabel& self, machine_learning::Context& ctx, const std::vector<Gate*>& subgraphs) -> std::optional<std::vector<std::vector<u32>>> {
+            [](const machine_learning::subgraph_label::SubgraphLabel& self, machine_learning::Context& ctx, const std::vector<std::vector<Gate*>>& subgraphs) -> std::optional<std::vector<std::vector<u32>>> {
                 auto res = self.calculate_labels(ctx, subgraphs);
                 if (res.is_ok())
                 {
@@ -111,7 +113,7 @@ Construct a ContainedComponents labeler.
 
         py_contained_components.def(
             "calculate_labels",
-            [](const machine_learning::subgraph_label::SubgraphLabel& self, machine_learning::Context& ctx, const std::vector<Gate*>& subgraphs) -> std::optional<std::vector<std::vector<u32>>> {
+            [](const machine_learning::subgraph_label::SubgraphLabel& self, machine_learning::Context& ctx, const std::vector<std::vector<Gate*>>& subgraphs) -> std::optional<std::vector<std::vector<u32>>> {
                 auto res = self.calculate_labels(ctx, subgraphs);
                 if (res.is_ok())
                 {
@@ -212,7 +214,7 @@ Construct a ContainedComponentsNetlist labeler.
 
         py_contained_components_netlist.def(
             "calculate_labels",
-            [](const machine_learning::subgraph_label::SubgraphLabel& self, machine_learning::Context& ctx, const std::vector<Gate*>& subgraphs) -> std::optional<std::vector<std::vector<u32>>> {
+            [](const machine_learning::subgraph_label::SubgraphLabel& self, machine_learning::Context& ctx, const std::vector<std::vector<Gate*>>& subgraphs) -> std::optional<std::vector<std::vector<u32>>> {
                 auto res = self.calculate_labels(ctx, subgraphs);
                 if (res.is_ok())
                 {
diff --git a/plugins/machine_learning/python/python_bindings.cpp b/plugins/machine_learning/python/python_bindings.cpp
diff --git a/plugins/machine_learning/src/features/gate_features/gate_feature.cpp b/plugins/machine_learning/src/features/gate_features/gate_feature.cpp
diff --git a/plugins/machine_learning/src/labels/subgraph_labels.cpp b/plugins/machine_learning/src/labels/subgraph_labels.cpp

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,8 @@ namespace hal`
`8`	`8`	`{`
`9`	`9`	`void bind_edge_features(py::module& m, py::module& py_edge_feature)`
`10`	`10`	`{`
	`11`	`+ UNUSED(m);`
	`12`	`+`
`11`	`13`	`py::class_<machine_learning::edge_feature::EdgeFeature, RawPtrWrapper<machine_learning::edge_feature::EdgeFeature>> py_edge_feature_class(py_edge_feature,`
`12`	`14`	`"EdgeFeature",`
`13`	`15`	`R"(`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,8 @@ namespace hal`
`8`	`8`	`{`
`9`	`9`	`void bind_gate_labels(py::module& m, py::module& py_gate_label)`
`10`	`10`	`{`
	`11`	`+ UNUSED(m);`
	`12`	`+`
`11`	`13`	`py::class_<machine_learning::gate_label::GateLabel, std::shared_ptr<machine_learning::gate_label::GateLabel>> py_gate_label_class(py_gate_label, "GateLabel", R"(`
`12`	`14`	`Base class for calculating labels for machine learning models.`
`13`	`15`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,8 @@ namespace hal`
`8`	`8`	`{`
`9`	`9`	`void bind_gate_pair_features(py::module& m, py::module& py_gate_pair_feature)`
`10`	`10`	`{`
	`11`	`+ UNUSED(m);`
	`12`	`+`
`11`	`13`	`// machine_learning::features::gate_pair_feature`
`12`	`14`	`py::class_<machine_learning::gate_pair_feature::GatePairFeature, std::shared_ptr<machine_learning::gate_pair_feature::GatePairFeature>> py_gate_pair_feature_class(`
`13`	`15`	`py_gate_pair_feature, "GatePairFeature", R"(`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,8 @@ namespace hal`
`8`	`8`	`{`
`9`	`9`	`void bind_gate_pair_labels(py::module& m, py::module& py_gate_pair_label)`
`10`	`10`	`{`
	`11`	`+ UNUSED(m);`
	`12`	`+`
`11`	`13`	`py::class_<machine_learning::gate_pair_label::GatePairLabel> py_gate_pair_label_class(py_gate_pair_label,`
`12`	`14`	`"GatePairLabel",`
`13`	`15`	`R"(`
Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,12 @@`
`1`		`-#include "bindings/register.h"`
	`1`	`+#include "register.h"`
`2`	`2`
`3`	`3`	`namespace hal`
`4`	`4`	`{`
`5`	`5`	`namespace machine_learning`
`6`	`6`	`{`
`7`	`7`	`namespace python`
`8`	`8`	`{`
`9`		`- void bind_core(py::module& m)`
	`9`	`+ void bind_plugin(py::module& m)`
`10`	`10`	`{`
`11`	`11`	`py::class_<MachineLearningPlugin, RawPtrWrapper<MachineLearningPlugin>, BasePluginInterface> py_machine_learning_plugin(`
`12`	`12`	`m, "MachineLearningPlugin", R"(Provides machine learning functionality as a plugin within the HAL framework.)");`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ namespace hal`
`8`	`8`	`{`
`9`	`9`	`namespace python`
`10`	`10`	`{`
`11`		`- void bind_core(py::module& m);`
	`11`	`+ void bind_plugin(py::module& m);`
`12`	`12`	`void bind_gate_features(py::module& m, py::module& py_gate_feature);`
`13`	`13`	`void bind_gate_pair_features(py::module& m, py::module& py_gate_pair_feature);`
`14`	`14`	`void bind_gate_pair_labels(py::module& m, py::module& py_gate_pair_label);`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,8 @@ namespace hal`
`8`	`8`	`{`
`9`	`9`	`void bind_subgraph_labels(py::module& m, py::module& py_subgraph_label)`
`10`	`10`	`{`
	`11`	`+ UNUSED(m);`
	`12`	`+`
`11`	`13`	`py::class_<machine_learning::subgraph_label::SubgraphLabel, std::shared_ptr<machine_learning::subgraph_label::SubgraphLabel>> py_subgraph_label_class(py_subgraph_label, "SubgraphLabel", R"(`
`12`	`14`	`Base class for calculating labels for machine learning models.`
`13`	`15`
`@@ -39,7 +41,7 @@ namespace hal`
`39`	`41`
`40`	`42`	`py_subgraph_label_class.def(`
`41`	`43`	`"calculate_labels",`
`42`		`- [](const machine_learning::subgraph_label::SubgraphLabel& self, machine_learning::Context& ctx, const std::vector<Gate*>& subgraphs) -> std::optional<std::vector<std::vector<u32>>> {`
	`44`	`+ [](const machine_learning::subgraph_label::SubgraphLabel& self, machine_learning::Context& ctx, const std::vector<std::vector<Gate*>>& subgraphs) -> std::optional<std::vector<std::vector<u32>>> {`
`43`	`45`	`auto res = self.calculate_labels(ctx, subgraphs);`
`44`	`46`	`if (res.is_ok())`
`45`	`47`	`{`
`@@ -111,7 +113,7 @@ Construct a ContainedComponents labeler.`
`111`	`113`
`112`	`114`	`py_contained_components.def(`
`113`	`115`	`"calculate_labels",`
`114`		`- [](const machine_learning::subgraph_label::SubgraphLabel& self, machine_learning::Context& ctx, const std::vector<Gate*>& subgraphs) -> std::optional<std::vector<std::vector<u32>>> {`
	`116`	`+ [](const machine_learning::subgraph_label::SubgraphLabel& self, machine_learning::Context& ctx, const std::vector<std::vector<Gate*>>& subgraphs) -> std::optional<std::vector<std::vector<u32>>> {`
`115`	`117`	`auto res = self.calculate_labels(ctx, subgraphs);`
`116`	`118`	`if (res.is_ok())`
`117`	`119`	`{`
`@@ -212,7 +214,7 @@ Construct a ContainedComponentsNetlist labeler.`
`212`	`214`
`213`	`215`	`py_contained_components_netlist.def(`
`214`	`216`	`"calculate_labels",`
`215`		`- [](const machine_learning::subgraph_label::SubgraphLabel& self, machine_learning::Context& ctx, const std::vector<Gate*>& subgraphs) -> std::optional<std::vector<std::vector<u32>>> {`
	`217`	`+ [](const machine_learning::subgraph_label::SubgraphLabel& self, machine_learning::Context& ctx, const std::vector<std::vector<Gate*>>& subgraphs) -> std::optional<std::vector<std::vector<u32>>> {`
`216`	`218`	`auto res = self.calculate_labels(ctx, subgraphs);`
`217`	`219`	`if (res.is_ok())`
`218`	`220`	`{`