Skip to content

Commit 4e197c4

Browse files
ereslibreereslibre
committed
chore: lint
1 parent 0c06497 commit 4e197c4

5 files changed

Lines changed: 29 additions & 24 deletions

File tree

‎.gitignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ packages/cli/*.jsonl
152152
packages/shared/dist
153153
packages/web/build
154154
packages/web/.svelte-kit
155+
packages/web/test-results
155156

156157
# Rover
157158
.rover/tasks/

‎packages/cli/tests/e2e/discovery.test.ts‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@ describe('Discovery', () => {
8181

8282
const claudeSource = sources.find(s => s.agent === 'claude');
8383
expect(claudeSource).toBeDefined();
84-
expect(claudeSource!.sessions.length).toBeGreaterThanOrEqual(1);
84+
expect(claudeSource?.sessions.length).toBeGreaterThanOrEqual(1);
8585

86-
const session = claudeSource!.sessions[0];
86+
const session = claudeSource?.sessions[0];
8787
expect(session.agent).toBe('claude');
8888
expect(session.title).toContain('Hello Claude');
8989
expect(session.date).toBeInstanceOf(Date);
@@ -116,9 +116,9 @@ describe('Discovery', () => {
116116

117117
const codexSource = sources.find(s => s.agent === 'codex');
118118
expect(codexSource).toBeDefined();
119-
expect(codexSource!.sessions.length).toBeGreaterThanOrEqual(1);
119+
expect(codexSource?.sessions.length).toBeGreaterThanOrEqual(1);
120120

121-
const session = codexSource!.sessions[0];
121+
const session = codexSource?.sessions[0];
122122
expect(session.agent).toBe('codex');
123123
expect(session.title).toContain('Fix the bug');
124124
});
@@ -149,9 +149,9 @@ describe('Discovery', () => {
149149

150150
const copilotSource = sources.find(s => s.agent === 'copilot');
151151
expect(copilotSource).toBeDefined();
152-
expect(copilotSource!.sessions.length).toBeGreaterThanOrEqual(1);
152+
expect(copilotSource?.sessions.length).toBeGreaterThanOrEqual(1);
153153

154-
const session = copilotSource!.sessions[0];
154+
const session = copilotSource?.sessions[0];
155155
expect(session.agent).toBe('copilot');
156156
expect(session.sessionId).toBe('copilot-test-001');
157157
});
@@ -178,9 +178,9 @@ describe('Discovery', () => {
178178

179179
const geminiSource = sources.find(s => s.agent === 'gemini');
180180
expect(geminiSource).toBeDefined();
181-
expect(geminiSource!.sessions.length).toBeGreaterThanOrEqual(1);
181+
expect(geminiSource?.sessions.length).toBeGreaterThanOrEqual(1);
182182

183-
const session = geminiSource!.sessions[0];
183+
const session = geminiSource?.sessions[0];
184184
expect(session.agent).toBe('gemini');
185185
expect(session.title).toContain('Create component');
186186
});
@@ -265,10 +265,10 @@ describe('Discovery', () => {
265265

266266
const claudeSource = sources.find(s => s.agent === 'claude');
267267
expect(claudeSource).toBeDefined();
268-
expect(claudeSource!.sessions.length).toBe(2);
268+
expect(claudeSource?.sessions.length).toBe(2);
269269

270270
// First session should be newer
271-
const [first, second] = claudeSource!.sessions;
271+
const [first, second] = claudeSource?.sessions ?? [];
272272
expect(first.date.getTime()).toBeGreaterThan(second.date.getTime());
273273
});
274274
});

‎packages/cli/tests/e2e/serve.test.ts‎

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,12 @@
22
// Source: packages/cli/E2E_TESTS.md — Suite: Serve
33
// Generator: /fp-generate
44

5-
import { createServer, type Server } from 'node:http';
5+
import {
6+
createServer,
7+
type IncomingMessage,
8+
type Server,
9+
type ServerResponse,
10+
} from 'node:http';
611
import { afterEach, describe, expect, it } from 'vitest';
712

813
describe('Serve', () => {
@@ -11,7 +16,7 @@ describe('Serve', () => {
1116
afterEach(async () => {
1217
if (server) {
1318
await new Promise<void>((resolve, reject) => {
14-
server!.close(err => (err ? reject(err) : resolve()));
19+
server?.close(err => (err ? reject(err) : resolve()));
1520
});
1621
server = undefined;
1722
}
@@ -20,15 +25,15 @@ describe('Serve', () => {
2025
// category: core
2126
it('starts HTTP server on specified port', async () => {
2227
// Create a minimal handler to test server binding
23-
const handler = (_req: any, res: any) => {
28+
const handler = (_req: IncomingMessage, res: ServerResponse) => {
2429
res.writeHead(200, { 'Content-Type': 'text/html' });
2530
res.end('<html><body>capsule</body></html>');
2631
};
2732

2833
server = createServer(handler);
2934

3035
await new Promise<void>(resolve => {
31-
server!.listen(0, '127.0.0.1', () => resolve());
36+
server?.listen(0, '127.0.0.1', () => resolve());
3237
});
3338

3439
const addr = server.address();
@@ -44,7 +49,7 @@ describe('Serve', () => {
4449

4550
// category: core
4651
it('accepts custom port via server.listen', async () => {
47-
const handler = (_req: any, res: any) => {
52+
const handler = (_req: IncomingMessage, res: ServerResponse) => {
4853
res.writeHead(200);
4954
res.end('ok');
5055
};
@@ -53,7 +58,7 @@ describe('Serve', () => {
5358

5459
// Use port 0 for random assignment
5560
await new Promise<void>(resolve => {
56-
server!.listen(0, '127.0.0.1', () => resolve());
61+
server?.listen(0, '127.0.0.1', () => resolve());
5762
});
5863

5964
const addr = server.address() as { port: number };
@@ -66,23 +71,23 @@ describe('Serve', () => {
6671

6772
// category: core
6873
it('handles graceful shutdown', async () => {
69-
const handler = (_req: any, res: any) => {
74+
const handler = (_req: IncomingMessage, res: ServerResponse) => {
7075
res.writeHead(200);
7176
res.end('ok');
7277
};
7378

7479
server = createServer(handler);
7580

7681
await new Promise<void>(resolve => {
77-
server!.listen(0, '127.0.0.1', () => resolve());
82+
server?.listen(0, '127.0.0.1', () => resolve());
7883
});
7984

8085
const addr = server.address() as { port: number };
8186
const port = addr.port;
8287

8388
// Close server (simulating SIGINT cleanup)
8489
await new Promise<void>((resolve, reject) => {
85-
server!.close(err => (err ? reject(err) : resolve()));
90+
server?.close(err => (err ? reject(err) : resolve()));
8691
});
8792

8893
// Verify the port is released - a new server should be able to bind
@@ -105,8 +110,8 @@ describe('Serve', () => {
105110

106111
// category: core
107112
it('responds with correct content-type for HTML', async () => {
108-
const handler = (_req: any, res: any) => {
109-
const url = new URL(_req.url, `http://${_req.headers.host}`);
113+
const handler = (_req: IncomingMessage, res: ServerResponse) => {
114+
const url = new URL(_req.url ?? '/', `http://${_req.headers.host}`);
110115
if (url.pathname === '/') {
111116
res.writeHead(200, { 'Content-Type': 'text/html' });
112117
res.end('<html></html>');
@@ -124,7 +129,7 @@ describe('Serve', () => {
124129

125130
server = createServer(handler);
126131
await new Promise<void>(resolve => {
127-
server!.listen(0, '127.0.0.1', () => resolve());
132+
server?.listen(0, '127.0.0.1', () => resolve());
128133
});
129134

130135
const addr = server.address() as { port: number };

‎packages/web/tests/e2e/gist-loading.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ test.describe('Gist Loading', () => {
7474

7575
// category: core
7676
// skip: requires-real-gist
77-
test.skip('gist loading with real GitHub API', async ({ page }) => {
77+
test.skip('gist loading with real GitHub API', async ({ page: _page }) => {
7878
// Skip reason: requires-real-gist
7979
// This test would load a known public gist and verify
8080
// content renders correctly. Requires network access.

‎packages/web/tests/e2e/upload-parse.spec.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import { expect, test } from '@playwright/test';
66
import {
7-
fixturePath,
87
uploadFixture,
98
waitForSessionInSidebar,
109
waitForTimeline,

0 commit comments

Comments
 (0)