Restrict native shuffle ops to Float32, Int32, and UInt32 for Metal#7
Merged
Merged
Conversation
…reactivate ComplexType @shfl test
Merged
epilliat
approved these changes
May 6, 2026
Owner
epilliat
left a comment
There was a problem hiding this comment.
Looks good — small, scoped, and CI-green. Removing the 8/16-bit Metal fast paths is the right call: Apple's AIR shuffle intrinsics are 32-bit only, so the previous code was emitting ccalls to non-existent symbols. The recursive widening in src/warp.jl:122-137 transparently routes narrow types through UInt32, so every bitstype that worked before still works — just one extra convert/reinterpret hop. The new ComplexTypeMetal test (Float16 in place of Float64, since MtlArray doesn't support FP64) is exactly the right coverage for the nested-struct path. Thanks!
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing from #5 (review)