refactor: rename getJobConditionFromJobStatus to findJobCondition for clarity

Richard87 · Richard87 · commit 6af39ecbcb2e · 2026-04-15T09:26:41.000+02:00
diff --git a/pkg/apis/job/job.go b/pkg/apis/job/job.go
@@ -252,7 +252,7 @@ func (job *Job) syncStatus(ctx context.Context, reconcileErr error) error {
 		if err != nil {
 			return err
 		}
-		condition, err = job.getJobConditionFromJobStatus(pipelineJob.Status)
+		condition, err = job.findJobCondition(pipelineJob.Status)
 		if err != nil {
 			return err
 		}
diff --git a/pkg/apis/job/kubejob.go b/pkg/apis/job/kubejob.go
@@ -272,7 +272,7 @@ func getPushImageTag(pushImage bool) string {
 	return "0"
 }
 
-func (job *Job) getJobConditionFromJobStatus(jobStatus batchv1.JobStatus) (radixv1.RadixJobCondition, error) {
+func (job *Job) findJobCondition(jobStatus batchv1.JobStatus) (radixv1.RadixJobCondition, error) {
 	if jobStatus.Failed > 0 {
 		return radixv1.JobFailed, nil
 	}

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ func (job *Job) syncStatus(ctx context.Context, reconcileErr error) error {`
`252`	`252`	`if err != nil {`
`253`	`253`	`return err`
`254`	`254`	`}`
`255`		`- condition, err = job.getJobConditionFromJobStatus(pipelineJob.Status)`
	`255`	`+ condition, err = job.findJobCondition(pipelineJob.Status)`
`256`	`256`	`if err != nil {`
`257`	`257`	`return err`
`258`	`258`	`}`
Original file line number	Diff line number	Diff line change
`@@ -272,7 +272,7 @@ func getPushImageTag(pushImage bool) string {`
`272`	`272`	`return "0"`
`273`	`273`	`}`
`274`	`274`
`275`		`-func (job *Job) getJobConditionFromJobStatus(jobStatus batchv1.JobStatus) (radixv1.RadixJobCondition, error) {`
	`275`	`+func (job *Job) findJobCondition(jobStatus batchv1.JobStatus) (radixv1.RadixJobCondition, error) {`
`276`	`276`	`if jobStatus.Failed > 0 {`
`277`	`277`	`return radixv1.JobFailed, nil`
`278`	`278`	`}`