update rpc store

Author: dimast-x

testing/README.md

@@ -2,30 +2,14 @@
 
 This directory contains tools for testing the Clearnode API by creating properly signed RPC messages and interacting with the Clearnode server.
 
-## Overview
-
-The testing toolkit consists of:
-
-1. **Go Client** - A command-line utility for creating and sending signed RPC messages
-2. **Interactive Shell Script** - A bash-based interactive menu for common testing operations
-
-These tools automatically handle authentication, private key management, and message signing according to the Clearnode protocol.
+The tool automatically handle authentication, private key management, and message signing according to the Clearnode protocol.
 
 ## Quick Start
 
-For most testing scenarios, use the interactive test script:
-
 ```bash
-# Set a custom server (optional)
-export SERVER="ws://your-server.com:8000/ws"
-
-# Run the interactive test menu
-./test_api.sh
-```
-
-Or use the Go client directly for specific operations:
+# Generate a signer key
+go run . --genkey 1    # Creates signer_key_1.hex
 
-```bash
 # Generate a signed message only
 go run . --method ping
 

testing/test_api.sh

@@ -219,6 +219,7 @@ func (h *UnifiedWSHandler) HandleConnection(w http.ResponseWriter, r *http.Reque
 
 		var rpcResponse = &RPCMessage{}
 		var handlerErr error
+		var recordHistory = false
 
 		// Track RPC request by method
 		h.metrics.RPCRequests.WithLabelValues(msg.Req.Method).Inc()
@@ -280,7 +281,7 @@ func (h *UnifiedWSHandler) HandleConnection(w http.ResponseWriter, r *http.Reque
 				continue
 			}
 			h.sendBalanceUpdate(address)
-
+			recordHistory = true
 		case "close_app_session":
 			rpcResponse, handlerErr = HandleCloseApplication(&msg, h.db)
 			if handlerErr != nil {
@@ -289,7 +290,7 @@ func (h *UnifiedWSHandler) HandleConnection(w http.ResponseWriter, r *http.Reque
 				continue
 			}
 			h.sendBalanceUpdate(address)
-
+			recordHistory = true
 		case "get_app_sessions":
 			rpcResponse, handlerErr = HandleGetAppSessions(&msg, h.db)
 			if handlerErr != nil {
@@ -305,15 +306,15 @@ func (h *UnifiedWSHandler) HandleConnection(w http.ResponseWriter, r *http.Reque
 				h.sendErrorResponse(address, &msg, conn, "Failed to resize channel: "+handlerErr.Error())
 				continue
 			}
-
+			recordHistory = true
 		case "close_channel":
 			rpcResponse, handlerErr = HandleCloseChannel(&msg, h.db, h.signer)
 			if handlerErr != nil {
 				log.Printf("Error handling close_channel: %v", handlerErr)
 				h.sendErrorResponse(address, &msg, conn, "Failed to close channel: "+handlerErr.Error())
 				continue
 			}
-
+			recordHistory = true
 		case "get_channels":
 			rpcResponse, handlerErr = HandleGetChannels(&msg, h.db)
 			if handlerErr != nil {
@@ -336,14 +337,16 @@ func (h *UnifiedWSHandler) HandleConnection(w http.ResponseWriter, r *http.Reque
 		}
 
 		// For broker methods, send back a signed RPC response.
-		byteData, _ := json.Marshal(rpcResponse.Req)
+		byteData, _ := json.Marshal(rpcResponse.Res)
 		signature, _ := h.signer.Sign(byteData)
 		rpcResponse.Sig = []string{hexutil.Encode(signature)}
 		wsResponseData, _ := json.Marshal(rpcResponse)
 
-		if err := h.rpcStore.StoreMessage(address, msg.Req, msg.Sig, byteData, rpcResponse.Sig); err != nil {
-			log.Printf("Failed to store RPC message: %v", err)
-			// continue processing even if storage fails
+		if recordHistory {
+			if err := h.rpcStore.StoreMessage(address, msg.Req, msg.Sig, byteData, rpcResponse.Sig); err != nil {
+				log.Printf("Failed to store RPC message: %v", err)
+				// continue processing even if storage fails
+			}
 		}
 
 		// Use NextWriter for safer message delivery