From 87b0b5d7fea68bdd9bb35a302c7648bff7e442f2 Mon Sep 17 00:00:00 2001
From: Mark Holt <135143369+mh0lt@users.noreply.github.com>
Date: Tue, 30 Apr 2024 16:54:07 +0100
Subject: [PATCH] add comments to continue clauses

---
 requesting.go | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/requesting.go b/requesting.go
index 7ecb4e2221..9799f96eff 100644
--- a/requesting.go
+++ b/requesting.go
@@ -312,12 +312,19 @@ func (p *Peer) applyRequestState(next desiredRequestState) {
 			panic("changed")
 		}
 
+		// don't add requests on receipt of a reject - because this causes request back
+		// to potentially permanently unresponsive peers - which just adds network noise.  If
+		// the peer can handle more requests it will send an "unchoked" message - which
+		// will cause it to get added back to the request queue
 		if p.needRequestUpdate == "Peer.remoteRejectedRequest" {
 			continue
 		}
 
 		existing := t.requestingPeer(req)
 		if existing != nil && existing != p {
+			// don't steal on cancel - because this is triggered by t.cancelRequest below
+			// which means that the cancelled can immediately try to steal back a request
+			// it has lost which can lead to circular cancel/add processing
 			if p.needRequestUpdate == "Peer.cancel" {
 				continue
 			}