Skip to content

Should tx.max_fee_per_gas < tx.max_priority_fee_per_gas be moved to validate_transaction? #2976

@SamWilsn

Description

@SamWilsn

This check requires no knowledge of the blockchain, so it doesn't really need to be in check_transaction.

if tx.max_fee_per_gas < tx.max_priority_fee_per_gas:
raise PriorityFeeGreaterThanMaxFeeError(
"priority fee greater than max fee"
)

EIP-1559 does the check after fetching the account, but that seems like a waste.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-spec-specsArea: Specification—The Ethereum specification itself (eg. `src/ethereum/*`)C-choreCategory: choreE-easyExperience: easy, good for newcomersS-needs-discussionStatus: needs discussion

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions