Skip to content

Miscellaneous improvements to the R package #12

@pcarbo

Description

@pcarbo

@eweine I'm going to use this issue to suggest a few miscellaneous improvements to the package. Please update the issue when you have made the suggested changes by checking off the item and/or posting a reply. I will also update this list periodically.

  • Update the description in DESCRIPTION to reflect our descriptions in the paper (e.g., I suggest introducing the terminology of "Poisson NMF with the shifted log link function").

  • We discussed this, but I think you should remove the version numbers for the dependencies except when we have good reason not to include them, e.g., for Rcpp, I think.

  • This seems like a strange default: fit_poisson_log1p_nmf_control_default()$threads = 7. I tend to think that a default of 1 is better. (Or set it automatically somehow using an environment variable or by detecting the number of available processors.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions