Skip to content

Dialyzer warnings from list_secret/1 and create_secret/1 #6

Description

@fmterrorf

The list_secret/1 typespec https://github.com/ex-aws/ex_aws_secretsmanager/blob/master/lib/ex_aws/secretsmanager.ex#L93-L98 indicates that it only accepts the following as an argument

  @type list_secrets_opts :: [
          {:max_results, integer} | {:next_token, binary}
        ]

The ListSecret API now accepts parameters such as Filters, SortOrder and others see https://docs.aws.amazon.com/secretsmanager/latest/apireference/API_ListSecrets.html.

Maybe we should just drop the list_secret_opts typespec or update it so that Dialyzer doesn't get mad

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions