Go to definition to function defined by macro with name ending in `?` or `!` does not work

[katafrakt]

This is a tracking issue for a bug found by a coworker. #759 added support for going to definition to functions defined by a macro. But turns out is only works for functions with "regular" names (for example MyApp.Repo.one/1) but not for the ones ending in ? or ! (MyApp.Repo.exists?/1)

I opened PR to ElixirSense already, but I think current HEAD of it does not pass tests in Expert, so even after the merge we'd have to figure something out (fork and cherry-pick for a time being, perhaps?).

elixir-lsp/elixir_sense#344

[doorgan]

We have the compiler tracer indexer on main which should be able to index macro defined functions, maybe this can be fixed on the expert side too?

[katafrakt]

I'll check that

[katafrakt]

#856 fixed it for functions defined by macros in the project codebase, but apparently not for dependencies (like Repo.exists?/1). Not sure if it should or if it's just something for wha we need ElixirSense fallback.

[doorgan]

I'm getting completions from them. Maybe you need to do a cold reindex? If so we should bump the index version to force that.

[katafrakt]

Yes, I get completions too. I think they are indexed, but it's something with go to definition itself. So far I have spent few hours on it, but haven't been able to pinpoint the reason.

[doorgan]

I get go to definition too, maybe it's some project specific bug?

Screen.Recording.2026-08-25.at.11.05.26.AM.mov

There it takes me to where the function is defined, which is the call site for the macro that injects that function. If we'd want that to take us to Ecto.Repo in the deps folder we'd need to add some Ecto specific handler or do it as part of #825

[katafrakt]

@doorgan but when you go to definition on AshHq.Repo.all, it will actually go to def all, right? This is the gap I'm trying to close.

[doorgan]

@katafrakt it does, and looking into it yeah it's the elixir sense fallback that does not recognize the ?/! functions, your fix to it should fix it for us
If we want to fix it within expert we'd need to do the same as elixir sense and do some extra analysis on generated functions, but the upstream patch should do

[katafrakt]

If we want to fix it within expert we'd need to do the same as elixir sense and do some extra analysis on generated functions

I've been experimenting with that for past few days, but it's was always a lot of code for not so big gain, so I decided not to PR that. Let's wait for the ElixirSense patch landing, I think - as we are relying on ElixirSense anyway.