Skip to content

Code refactoring #53

@hannahgooding

Description

@hannahgooding

AboutPage.js

Line 24
There's a rouge toclassName={classes.title} in your copy showing up on the website 🙊

Importing fetch requests

Review Page.js
Would be cleaner to move the fetch request function into your utils and import it 😇

Readability with loading states for pages

Some great advice we got from Izaak on our refactoring our code is using if statements instead of loads of nested ternaries for rendering. Makes it so much more readable and meaningful 🙌

For example:

const isLoading = fetchState === ' ';

if (isLoading) {
  // return loading state
} else {
 // return your amazing website content
}

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions