Skip to content

mhr_head.py: comment says '# B x 127' but actual dimension is 136 #124

Description

@CedricYauLBD

Bug

In sam_3d_body/models/heads/mhr_head.py, the mhr_forward() method has a comment # B x 127 on the line where full_pose_params is assembled:

full_pose_params = torch.cat([global_trans * 10, global_rot, body_pose_params], dim=1)  # B x 127

The actual dimension is 136 (3 global_trans + 3 global_rot + 130 body_pose_params), not 127. The MHR paper (arXiv:2511.15586, Section 3.1) confirms n_pose = 136.

127 is the number of joints in the MHR skeleton, not the number of pose parameters.

Suggested fix

full_pose_params = torch.cat([global_trans * 10, global_rot, body_pose_params], dim=1)  # B x 136 (3 trans + 3 rot + 130 body_pose)

Found during a documentation audit of the SAM-3D-Body / MHR parameter pipeline.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions