Fallow should not detect function calls as duplicate #320
danielo515
started this conversation in
General
Replies: 1 comment 1 reply
-
|
Released in v2.70.0. Thanks @danielo515. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hello, and before anything, thanks for this tool. I'm trying to put it to good use.
I noticed that a lot of the reported duplicates are just function calls. Some functions require certain number of arguments, and they can easily span more than 5 lines, which is the default detection length for duplicates.
A function call requires values in scope and it's already a single "entity" abstraction, so it can not be deduplicated any further. I don't think fallow should flag identical function calls as duplicates, because what possible solution there is? To write a macro? A function that just calls the other function?
Beta Was this translation helpful? Give feedback.
All reactions