From 29511d63b6775bf948c613d12096d2342d1b73be Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Mon, 14 Sep 2026 06:54:58 +0000 Subject: [PATCH 1/2] fix(FLEETMDM-009): 2 review findings across 2 files --- .../homebrew/external_refs/cisco_jabber_version_transformer.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ee/maintained-apps/ingesters/homebrew/external_refs/cisco_jabber_version_transformer.go b/ee/maintained-apps/ingesters/homebrew/external_refs/cisco_jabber_version_transformer.go index be81febcc2b..4889615656f 100644 --- a/ee/maintained-apps/ingesters/homebrew/external_refs/cisco_jabber_version_transformer.go +++ b/ee/maintained-apps/ingesters/homebrew/external_refs/cisco_jabber_version_transformer.go @@ -7,6 +7,7 @@ import ( // CiscoJabberVersionTransformer sets the version to "15.2.0" which matches what osquery reports. // Homebrew reports a build number (e.g., "20251027035315") instead of the app version (e.g., "15.2.0"). func CiscoJabberVersionTransformer(app *maintained_apps.FMAManifestApp) (*maintained_apps.FMAManifestApp, error) { - app.Version = "15.2.1" + app.Version = "15.2.0" return app, nil } + From 0190908bbcd923252222acee1d149b1d6a385f9b Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Mon, 14 Sep 2026 06:54:59 +0000 Subject: [PATCH 2/2] fix(FLEETMDM-009): 2 review findings across 2 files --- .../homebrew/scripts/grammarly-desktop-install.sh | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ee/maintained-apps/inputs/homebrew/scripts/grammarly-desktop-install.sh b/ee/maintained-apps/inputs/homebrew/scripts/grammarly-desktop-install.sh index bdd41483d0e..0d30fa4f403 100755 --- a/ee/maintained-apps/inputs/homebrew/scripts/grammarly-desktop-install.sh +++ b/ee/maintained-apps/inputs/homebrew/scripts/grammarly-desktop-install.sh @@ -45,7 +45,15 @@ quit_application() { # extract contents MOUNT_POINT=$(mktemp -d /tmp/dmg_mount_XXXXXX) -hdiutil attach -plist -nobrowse -readonly -mountpoint "$MOUNT_POINT" "$INSTALLER_PATH" +if ! hdiutil attach -plist -nobrowse -readonly -mountpoint "$MOUNT_POINT" "$INSTALLER_PATH"; then + echo "Error: failed to mount $INSTALLER_PATH" + exit 1 +fi +if [ -z "$(ls -A "$MOUNT_POINT" 2>/dev/null)" ]; then + echo "Error: mount point $MOUNT_POINT is empty after mounting $INSTALLER_PATH" + hdiutil detach "$MOUNT_POINT" >/dev/null 2>&1 + exit 1 +fi sudo cp -R "$MOUNT_POINT"/* "$TMPDIR" hdiutil detach "$MOUNT_POINT"