Skip to content

cmake.py/run_build() adds Visual Studio args for Android builds #251

@floooh

Description

@floooh

See here:

cmdLine += ' -- /nologo /verbosity:minimal /maxcpucount:{} {}'.format(num_jobs, args_str)

The code assumes that all builds on Windows are done with Visual Studio, and on all other platforms with a build tool which understands the -j option. Needs to be changed to check the build tool instead.

This produces problems like:

=== building: android-vscode-debug
cmake --build . --config Debug -- /nologo /verbosity:minimal /maxcpucount:10
ninja: error: unknown target '/nologo'
[ERROR] Failed to build config 'android-vscode-debug' of project 'X'

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions