forgo.mount() typing not matching with behaviour

[chronoDave]

When trying to run the following code I got an unexpected error:

import * as forgo from "forgo";

const App= () =>
  new forgo.Component({
    render() {
      return <p>Tooltip</p>;
    }
  });

forgo.mount(document.getElementById("root"), <App />);

forgo.min.js:520 Uncaught Error: The container argument to the mount() function should be an HTML element.

Now, because of the typing of mount(), this doesn't throw an error, though I'm not sure why.

export function mount(
  forgoNode: ForgoNode,
  container: Element | string | null
): RenderResult {
  return forgoInstance.mount(forgoNode, container);
}

null however is never a valid container because if (parentElement) will always return false.

[chronoDave]

Sandbox

[spiffytech]

You have the arguments reversed. This works:

forgo.mount(<App />, document.getElementById("root"));

I'll see if I can tighten up the type signature to blow up correctly.

[spiffytech]

I'm going to wait on this types change until we publish breaking changes is v4.0. Since document.getElementById() returns type HTMLElement | null, disallowing null would be a breaking change as it would force existing call sites to add a non-null ! assertion.