feat: expand bundle-backed PartListItems inline in the tree#2
Conversation
There was a problem hiding this comment.
Pull request overview
Expands the Item Explorer tree behavior so that Part List items that are actually backed by a Product Bundle can be expanded inline (showing bundle contents), and ensures toolbar actions apply to these bundle-typed nodes.
Changes:
- Treat Part List children as regular items by running them through
set_expandable()(allowing bundle-backed items to become expandable and typed asProduct Bundle). - Remove manual type assignment for Part List items and rely on
set_expandable()to settype/expandable. - Allow
Product Bundle-typed nodes to use existing tree toolbar actions (Copy / Open Item).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
item_explorer/item_explorer/doctype/item_explorer/item_explorer_tree.js |
Adds Product Bundle to toolbar action eligibility checks so bundle-typed nodes can be copied/opened like other item nodes. |
item_explorer/item_explorer/doctype/item_explorer/item_explorer.py |
Updates Part List item generation to call set_expandable() so bundle-backed Part List items can be expanded inline (and ensures type is set before add_value_json_field). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Namekkural
left a comment
There was a problem hiding this comment.
Sieht gut aus, hast du es lokal getestet? Das sollte man auf jeden Fall einmal machen.
|
Nee, hab ERPNext local noch nicht aufgesetzt, hatte geplant es mit dem App-Branch-Feature in Frappe-Cloud zu testen. Haben wir da ein Repo/eine Anleitung für's lokale Setup von ERP mit Live-Daten? |
|
Phil hat das zuletzt mal gut hinbekommen, kannst es aber auch gern auf erp-test ausprobieren. Fürs integrieren ist lokal besser |
No description provided.