Phase 8: docs (CHANGELOG, ARCHITECTURE, CONTRIBUTING, TROUBLESHOOTING, CWS_REVIEW)#10
Conversation
…IEW (Phase 8 of code review) Документации почти не было: README + PRIVACY + SECURITY и пара docs/LAUNCH/RECORDING.md. Для CWS submission и внешних контрибьюторов нужен минимальный набор. - CHANGELOG.md (Keep a Changelog format): Unreleased секция содержит всё что прошло через PR-1..PR-7 — security/security/i18n/providers/ selectors/SW-keepalive/MCP-cache/tooling. CWS reviewers смотрят changelog между версиями. - CONTRIBUTING.md: layout проекта, local dev, code style, как добавлять провайдеры / DOM-стратегии / i18n-строки, commit/PR conventions, bug-report format с обязательным dump tta_selector_health. - docs/ARCHITECTURE.md: диаграмма data-flow content_script <-> SW <-> AI providers / MCP, описание компонентов, persistence layout (storage.sync / .local / .session / in-memory). "Что лежит off-disk" явно: ничего, no telemetry. - docs/TROUBLESHOOTING.md: pathways когда X сломался, ключ битый, SW засыпает, rate-limit, MCP offline. Каждая секция указывает на конкретные DevTools-команды и storage-ключи для диагностики. - docs/CWS_REVIEW.md: внутренний чеклист submission — manifest hygiene, code checks, store-listing assets, permission justifications таблицей (для соответствующего поля в dev console). - README.md: секция Releasing переписана с ручного zip на npm run package. Ссылки на CONTRIBUTING/ARCHITECTURE/TROUBLESHOOTING. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13f38beb44
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - Options → Advanced → For developers → MCP Gateway → **Test**. | ||
| - Confirm `mcpUrl` matches what your local MCP server is listening on. | ||
| - TweAI 1.8.1+ moved localhost into `optional_host_permissions`. The first time you set an MCP URL, Chrome will prompt you to grant `http://127.0.0.1/*` permission — accept it. If you didn't, the request will fail without a clear error. |
There was a problem hiding this comment.
When MCP is enabled, this troubleshooting step says Chrome will prompt for the optional localhost host permission, but I checked the repo for chrome.permissions and there is no code path that calls chrome.permissions.request; mcpFetch only reads prefs.mcpUrl and fetches it. With localhost only in optional_host_permissions, users will not see the described prompt, so enabling MCP can keep failing while this guide points them at an action they cannot take.
Useful? React with 👍 / 👎.
1 participant
Summary
Финальный PR серии — документация. Раньше было только README + PRIVACY + SECURITY + пара marketing-doc'ов. Для CWS submission и внешних контрибьюторов нужен минимальный набор.
Что добавлено
CHANGELOG.mdCONTRIBUTING.mdnpm install/npm run lint/npm run package), code style, как добавлять провайдеры / DOM-стратегии / i18n. Bug-report шаблон требует dumptta_selector_health.docs/ARCHITECTURE.mddocs/TROUBLESHOOTING.mddocs/CWS_REVIEW.mdREADME.mdzipнаnpm run package. Ссылки на CONTRIBUTING / ARCHITECTURE / TROUBLESHOOTING.Что НЕ добавлено
docs/CWS_REVIEW.mdэто явно отмечено как открытый пункт. Сделать вручную перед submission.Test plan
docs/CWS_REVIEW.mdчеклист проходим end-to-end на текущем состоянии main🤖 Generated with Claude Code