fix(web-admin): variableNameForRole uses wrong suffix APP_ID vs CLIENT_ID

[ggallen]

Context

Pre-existing bug in the web admin code, surfaced during PR #2517 review.

Problem

web/admin/src/lib/layers/secrets.ts:10 generates FULLSEND_{ROLE}_APP_ID but the Go backend uses FULLSEND_{ROLE}_CLIENT_ID (internal/layers/secrets.go:187). This causes the admin UI to report incorrect missing variables.

Fix

Update variableNameForRole to use the _CLIENT_ID suffix matching the backend.

References

• Flagged by review squad on PR refactor(config): remove OrgConfig.Agents field (ADR-0045 Phase 4 PR 4) #2517

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 7:15 PM UTC · Completed 7:20 PM UTC
Commit: 4e21a60 · View workflow run →

[fullsend-ai-triage]

Triage Summary

Severity: Medium · Category: Bug

The variableNameForRole function in web/admin/src/lib/layers/secrets.ts generates variable names with a _APP_ID suffix, but the Go backend's variableName in internal/layers/secrets.go:187 uses _CLIENT_ID. This suffix mismatch causes the admin UI to check for the wrong GitHub Actions variables and report incorrect missing-variable diagnostics.

Root Cause

The TypeScript port used the wrong suffix when translating the backend's variable naming logic. The secret name function (_APP_PRIVATE_KEY) is correct — only the variable name function has the discrepancy.

Recommended Fix

Change line 10 of web/admin/src/lib/layers/secrets.ts:

- return `FULLSEND_${role.toUpperCase()}_APP_ID`;
+ return `FULLSEND_${role.toUpperCase()}_CLIENT_ID`;

Proposed Test

// Verify variable name matches Go backend convention
assert(variableNameForRole('triage') === 'FULLSEND_TRIAGE_CLIENT_ID');
assert(variableNameForRole('code') === 'FULLSEND_CODE_CLIENT_ID');

This is a one-line fix with a clear, confirmed root cause. Good candidate for a quick patch.

---

Labels: Confirmed defect in the web admin secrets layer with medium severity; suitable for newcomers given it is a one-line fix.

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 7:23 PM UTC · Completed 8:00 PM UTC
Commit: 4e21a60 · View workflow run →