fix(web-admin): VALID_ROLES has 4 roles vs Go's 8

[ggallen]

Context

Pre-existing bug in the web admin code, surfaced during PR #2517 review.

Problem

web/admin/src/lib/layers/orgConfigParse.ts:18 defines VALID_ROLES as ["fullsend", "triage", "coder", "review"] but Go's ValidRoles() includes 8 roles: fullsend, triage, coder, review, fix, retro, prioritize, e2e. This means the UI rejects configs that the backend accepts.

Fix

Update VALID_ROLES to match Go's ValidRoles().

References

• Flagged by review squad on PR refactor(config): remove OrgConfig.Agents field (ADR-0045 Phase 4 PR 4) #2517

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 7:14 PM UTC · Completed 7:16 PM UTC
Commit: 4e21a60 · View workflow run →

[fullsend-ai-triage]

Triage Summary

Severity: Medium · Category: Bug

Problem

The VALID_ROLES constant in the web admin TypeScript code defines only 4 roles, while the Go backend's ValidRoles() defines 8. The missing roles are: fix, retro, prioritize, and e2e. This causes the UI to reject valid org configurations that use these roles.

Root Cause

The TypeScript constant was not updated when new roles were added to the Go backend.

Recommended Fix

Update VALID_ROLES in web/admin/src/lib/layers/orgConfigParse.ts (line 18) to include all 8 roles. Consider adding a comment referencing Go's ValidRoles() as the source of truth to prevent future drift.

Proposed Test

Test: VALID_ROLES contains all backend-supported roles
- Assert each of the 8 roles (fullsend, triage, coder, review, fix, retro, prioritize, e2e) passes validation
- Assert an unknown role like 'nonexistent' is rejected
- This prevents future drift between frontend and backend role lists

This is a well-scoped fix — good candidate for a quick PR.

---

Labels: Web admin bug with clear fix, medium priority since it blocks UI configuration of newer agent roles.

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 7:22 PM UTC · Completed 7:26 PM UTC
Commit: 4e21a60 · View workflow run →