Isolate pack builder PACK_HOME for parallel test execution

Parallel func deploy calls with the pack builder corrupt the shared
~/.pack/volume-keys.toml file, causing deterministic failures. Create
a per-deploy temporary PACK_HOME directory when using the pack builder
via the new EnvVars deploy option.

Author: creydr

test/utils/func.go

@@ -81,6 +81,21 @@ func RunFuncDeploy(functionDir string, optFns ...FuncDeployOption) (string, erro
 		args = append(args, "--deployer", opts.Deployer)
 	}
 
+	// When using the pack builder, create a per-deploy PACK_HOME to prevent
+	// parallel builds from corrupting the shared ~/.pack/volume-keys.toml.
+	if opts.Builder == "pack" {
+		packHome, err := os.MkdirTemp("", "pack-home-*")
+		if err != nil {
+			return "", fmt.Errorf("failed to create PACK_HOME: %w", err)
+		}
+		defer os.RemoveAll(packHome)
+
+		if opts.EnvVars == nil {
+			opts.EnvVars = make(map[string]string)
+		}
+		opts.EnvVars["PACK_HOME"] = packHome
+	}
+
 	var output string
 	var err error
 
@@ -96,12 +111,22 @@ func RunFuncDeploy(functionDir string, optFns ...FuncDeployOption) (string, erro
 			retryDelay *= 2
 		}
 
+		var funcBinary string
 		if opts.CliVersion != "" {
-			output, err = RunFuncWithVersion(opts.CliVersion, "deploy", args...)
+			funcBinary, err = ensureFuncVersion(opts.CliVersion)
+			if err != nil {
+				return "", err
+			}
 		} else {
-			output, err = RunFunc("deploy", args...)
+			funcBinary = "func"
 		}
 
+		cmd := exec.Command(funcBinary, append([]string{"deploy"}, args...)...)
+		for k, v := range opts.EnvVars {
+			cmd.Env = append(cmd.Env, fmt.Sprintf("%s=%s", k, v))
+		}
+		output, err = Run(cmd)
+
 		if err == nil {
 			return output, nil
 		}
@@ -117,6 +142,7 @@ type FuncDeployOptions struct {
 	Builder          string
 	Deployer         string
 	CliVersion       string
+	EnvVars          map[string]string
 }
 
 type FuncDeployOption func(*FuncDeployOptions)
@@ -145,6 +171,12 @@ func WithDeployCliVersion(version string) FuncDeployOption {
 	}
 }
 
+func WithEnvVars(envVars map[string]string) FuncDeployOption {
+	return func(opts *FuncDeployOptions) {
+		opts.EnvVars = envVars
+	}
+}
+
 // ensureFuncVersion ensures the specified func version is available and returns its path
 func ensureFuncVersion(version string) (string, error) {
 	projectDir, err := GetProjectDir()

test/utils/utils.go

@@ -36,7 +36,7 @@ func Run(cmd *exec.Cmd) (string, error) {
 		_, _ = fmt.Fprintf(GinkgoWriter, "chdir dir: %q\n", err)
 	}
 
-	cmd.Env = append(os.Environ(), "GO111MODULE=on")
+	cmd.Env = append(append(os.Environ(), cmd.Env...), "GO111MODULE=on")
 	command := strings.Join(cmd.Args, " ")
 	_, _ = fmt.Fprintf(GinkgoWriter, "running: %q\n", command)
 	output, err := cmd.CombinedOutput()