Ensure git clone base directory exists on startup

Create /git-repos directory in NewManager() if it doesn't exist,
providing a safety net for environments where the emptyDir volume
mount may not be configured.

Author: creydr

cmd/main.go

@@ -348,12 +348,18 @@ func main() {
 	}
 	setupLog.Info("Func CLI is ready")
 
+	gitManager, err := git.NewManager()
+	if err != nil {
+		setupLog.Error(err, "failed to initialize git manager")
+		os.Exit(1)
+	}
+
 	if err := (&controller.FunctionReconciler{
 		Client:            mgr.GetClient(),
 		Scheme:            mgr.GetScheme(),
 		Recorder:          mgr.GetEventRecorder("functions-controller"),
 		FuncCliManager:    funcCLIManager,
-		GitManager:        git.NewManager(),
+		GitManager:        gitManager,
 		OperatorNamespace: operatorNamespace,
 	}).SetupWithManager(mgr); err != nil {
 		setupLog.Error(err, "unable to create controller", "controller", "Function")

internal/git/manager.go

@@ -23,8 +23,11 @@ type Manager interface {
 	CloneRepository(ctx context.Context, url, subPath, reference string, auth map[string][]byte) (*Repository, error)
 }
 
-func NewManager() Manager {
-	return &managerImpl{}
+func NewManager() (Manager, error) {
+	if err := os.MkdirAll(cloneBaseDir, 0755); err != nil {
+		return nil, fmt.Errorf("failed to create git clone base directory: %w", err)
+	}
+	return &managerImpl{}, nil
 }
 
 type managerImpl struct{}