Remove function.Metadata and switch to fn.NewFunction (#123)

Author: creydr

internal/controller/function_controller.go

@@ -25,7 +25,6 @@ import (
 	"time"
 
 	"github.com/functions-dev/func-operator/internal/funccli"
-	fn "github.com/functions-dev/func-operator/internal/function"
 	"github.com/functions-dev/func-operator/internal/git"
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -200,7 +199,7 @@ func (r *FunctionReconciler) prepareSource(ctx context.Context, function *v1alph
 		return nil, nil, fmt.Errorf("failed to setup git repository: %w", err)
 	}
 
-	metadata, err := fn.Metadata(repo.Path())
+	metadata, err := funcfn.NewFunction(repo.Path())
 	if err != nil {
 		function.MarkSourceNotReady("MetadataReadFailed", "Failed to read function metadata: %s", err.Error())
 		return nil, nil, fmt.Errorf("failed to get function metadata: %w", err)

internal/function/metadata.go

@@ -25,7 +25,6 @@ import (
 	"time"
 
 	functionsdevv1alpha1 "github.com/functions-dev/func-operator/api/v1alpha1"
-	"github.com/functions-dev/func-operator/internal/function"
 	"github.com/functions-dev/func-operator/test/utils"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
@@ -108,7 +107,7 @@ var _ = Describe("Middleware Update", func() {
 
 		It("should update the middleware and mark the function as ready", func() {
 			// Get function metadata to retrieve the deployed function name
-			funcMetadata, err := function.Metadata(repoDir)
+			funcMetadata, err := funcfn.NewFunction(repoDir)
 			Expect(err).NotTo(HaveOccurred())
 			deployedFunctionName := funcMetadata.Name