fix: Set service status in status initially too (#85)

Author: creydr

internal/controller/function_controller.go

@@ -219,6 +219,7 @@ func (r *FunctionReconciler) handleMiddlewareUpdate(ctx context.Context, functio
 		return fmt.Errorf("failed to describe function to get image details: %w", err)
 	}
 	function.Status.Deployment.Image = functionDescribe.Image
+	markServiceStatus(functionDescribe.Ready, function)
 
 	isMiddlewareUpdateEnabled, source, err := r.isMiddlewareUpdateEnabled(ctx, function)
 	if err != nil {
@@ -285,19 +286,22 @@ func (r *FunctionReconciler) handleMiddlewareUpdate(ctx context.Context, functio
 	}
 	function.Status.Deployment.Image = functionDescribe.Image
 	function.Status.Middleware.Current = functionDescribe.Middleware.Version
+	markServiceStatus(functionDescribe.Ready, function)
 
 	function.MarkDeployReady()
 
-	switch functionDescribe.Ready {
+	return nil
+}
+
+func markServiceStatus(ready string, function *v1alpha1.Function) {
+	switch strings.ToLower(ready) {
 	case "true":
 		function.MarkServiceReady()
 	case "false":
 		function.MarkServiceNotReady("ServiceNotReady", "Underlying service is not ready")
 	default:
 		function.MarkServiceNotReady("ServiceReadyUnknown", "Underlying service readiness is unknown")
 	}
-
-	return nil
 }
 
 func (r *FunctionReconciler) setupPipelineRBAC(ctx context.Context, function *v1alpha1.Function) error {