Update status conditions on reconcile error

Author: creydr

api/v1alpha1/function_lifecycle.go

@@ -0,0 +1,30 @@
+package v1alpha1
+
+import (
+	"fmt"
+
+	"k8s.io/apimachinery/pkg/api/meta"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+const (
+	FunctionConditionDeployed = "Deployed"
+)
+
+func (s *FunctionStatus) MarkDeploySucceeded() bool {
+	return meta.SetStatusCondition(&s.Conditions, metav1.Condition{
+		Type:    FunctionConditionDeployed,
+		Status:  metav1.ConditionTrue,
+		Reason:  "Succeeded",
+		Message: "Function has been successfully deployed",
+	})
+}
+
+func (s *FunctionStatus) MarkDeployFailed(reason, messageFormat string, messageA ...interface{}) bool {
+	return meta.SetStatusCondition(&s.Conditions, metav1.Condition{
+		Type:    FunctionConditionDeployed,
+		Status:  metav1.ConditionFalse,
+		Reason:  reason,
+		Message: fmt.Sprintf(messageFormat, messageA...),
+	})
+}

api/v1alpha1/function_types.go

@@ -23,6 +23,9 @@ import (
 
 // +kubebuilder:object:root=true
 // +kubebuilder:subresource:status
+// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"
+// +kubebuilder:printcolumn:name="Ready",type="string",JSONPath=".status.conditions[?(@.type==\"Deployed\")].status",description="Ready Condition Status"
+// +kubebuilder:printcolumn:name="Reason",type="string",JSONPath=".status.conditions[?(@.type==\"Deployed\")].reason",description="Ready Condition Reason"
 
 // Function is the Schema for the functions API.
 type Function struct {

config/crd/bases/functions.dev_functions.yaml

@@ -14,7 +14,19 @@ spec:
     singular: function
   scope: Namespaced
   versions:
-  - name: v1alpha1
+  - additionalPrinterColumns:
+    - jsonPath: .metadata.creationTimestamp
+      name: Age
+      type: date
+    - description: Ready Condition Status
+      jsonPath: .status.conditions[?(@.type=="Deployed")].status
+      name: Ready
+      type: string
+    - description: Ready Condition Reason
+      jsonPath: .status.conditions[?(@.type=="Deployed")].reason
+      name: Reason
+      type: string
+    name: v1alpha1
     schema:
       openAPIV3Schema:
         description: Function is the Schema for the functions API.

internal/controller/function_controller.go

@@ -67,10 +67,46 @@ type FunctionReconciler struct {
 // +kubebuilder:rbac:groups=tekton.dev,resources=taskruns,verbs=get;list;watch
 // +kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=rolebindings,verbs=get;list;watch;create;update;patch;delete
 
-// Reconcile a Function
+// Reconcile a Function with status update on error
 func (r *FunctionReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
 	logger := logf.FromContext(ctx)
 
+	reconcileRes, reconcileErr := r.reconcile(ctx, req)
+
+	function := &v1alpha1.Function{}
+	if err := r.Get(ctx, req.NamespacedName, function); err != nil {
+		// we can't get the function to update the status -> return early
+		if apierrors.IsNotFound(err) {
+			// function was already deleted -> nothing to update
+			return ctrl.Result{}, nil
+		}
+		logger.Error(err, "Unable to fetch Function to update status condition", "reconcileError", reconcileErr)
+		return reconcileRes, reconcileErr
+	}
+
+	statusUpdated := false
+	if reconcileErr != nil {
+		// update status condition with error
+		statusUpdated = function.Status.MarkDeployFailed("ReconcileError", "%s", reconcileErr.Error())
+	} else {
+		// clear previous errors
+		statusUpdated = function.Status.MarkDeploySucceeded()
+	}
+
+	if statusUpdated {
+		// update status
+		if err := r.Status().Update(ctx, function); err != nil {
+			logger.Error(err, "Unable to update Function status conditions", "functionName", function.Name, "functionNamespace", function.Namespace)
+			return reconcileRes, reconcileErr
+		}
+	}
+
+	return reconcileRes, reconcileErr
+}
+
+func (r *FunctionReconciler) reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
+	logger := logf.FromContext(ctx)
+
 	function := &v1alpha1.Function{}
 	err := r.Get(ctx, req.NamespacedName, function)
 	if err != nil {