Collect logs on test failure

Author: creydr

test/e2e/bundle_test.go

@@ -86,11 +86,36 @@ var _ = Describe("Bundle", Ordered, func() {
 	})
 
 	AfterEach(func() {
-		By("Cleaning up all resources")
-		for _, ns := range []string{namespace1, namespace2, namespace3, namespace4} {
-			cmd := exec.Command("kubectl", "delete", "namespace", ns, "--ignore-not-found")
-			_, err := utils.Run(cmd)
-			Expect(err).NotTo(HaveOccurred())
+		specReport := CurrentSpecReport()
+		if !specReport.Failed() {
+			By("Cleaning up all resources")
+			for _, ns := range []string{namespace1, namespace2, namespace3, namespace4} {
+				cmd := exec.Command("kubectl", "delete", "namespace", ns, "--ignore-not-found")
+				_, err := utils.Run(cmd)
+				Expect(err).NotTo(HaveOccurred())
+			}
+		} else {
+			// collect logs in case it failed
+			By("Collecting logs from deployed operators")
+			for _, ns := range []string{namespace1, namespace2, namespace3, namespace4} {
+				By("Logs from operator in namespace " + ns)
+				cmd := exec.Command("kubectl", "logs", "-l", "control-plane=controller-manager", "--namespace", ns)
+				controllerLogs, err := utils.Run(cmd)
+				if err == nil {
+					_, _ = fmt.Fprintf(GinkgoWriter, "Controller logs:\n %s", controllerLogs)
+				} else {
+					_, _ = fmt.Fprintf(GinkgoWriter, "Failed to get Controller logs: %s", err)
+				}
+			}
+
+			By("Collecting functions")
+			cmd := exec.Command("kubectl", "get", "function", "-A", "-o", "yaml")
+			out, err := utils.Run(cmd)
+			if err == nil {
+				_, _ = fmt.Fprintf(GinkgoWriter, "Functions:\n %s", out)
+			} else {
+				_, _ = fmt.Fprintf(GinkgoWriter, "Failed to get functions: %s", err)
+			}
 		}
 	})
 
@@ -111,12 +136,14 @@ var _ = Describe("Bundle", Ordered, func() {
 		})
 
 		AfterAll(func() {
-			By("Uninstalling the operator")
-			out, err := utils.OperatorSdkRun("cleanup",
-				"--namespace", namespace1,
-				"--delete-all")
-			Expect(err).NotTo(HaveOccurred())
-			_, _ = fmt.Fprint(GinkgoWriter, out)
+			specReport := CurrentSpecReport()
+			if !specReport.Failed() {
+				By("Uninstalling the operator")
+				out, err := utils.OperatorSdkRun("cleanup",
+					"--namespace", namespace1)
+				Expect(err).NotTo(HaveOccurred())
+				_, _ = fmt.Fprint(GinkgoWriter, out)
+			}
 		})
 
 		It("should reconcile function in own namespace", func() {
@@ -140,12 +167,14 @@ var _ = Describe("Bundle", Ordered, func() {
 		})
 
 		AfterAll(func() {
-			By("Uninstalling the operator")
-			out, err := utils.OperatorSdkRun("cleanup",
-				"--namespace", namespace1,
-				"--delete-all")
-			Expect(err).NotTo(HaveOccurred())
-			_, _ = fmt.Fprint(GinkgoWriter, out)
+			specReport := CurrentSpecReport()
+			if !specReport.Failed() {
+				By("Uninstalling the operator")
+				out, err := utils.OperatorSdkRun("cleanup",
+					"--namespace", namespace1)
+				Expect(err).NotTo(HaveOccurred())
+				_, _ = fmt.Fprint(GinkgoWriter, out)
+			}
 		})
 
 		It("should reconcile function in dedicated namespace", func() {
@@ -170,12 +199,14 @@ var _ = Describe("Bundle", Ordered, func() {
 		})
 
 		AfterAll(func() {
-			By("Uninstalling the operator")
-			out, err := utils.OperatorSdkRun("cleanup",
-				"--namespace", namespace1,
-				"--delete-all")
-			Expect(err).NotTo(HaveOccurred())
-			_, _ = fmt.Fprint(GinkgoWriter, out)
+			specReport := CurrentSpecReport()
+			if !specReport.Failed() {
+				By("Uninstalling the operator")
+				out, err := utils.OperatorSdkRun("cleanup",
+					"--namespace", namespace1)
+				Expect(err).NotTo(HaveOccurred())
+				_, _ = fmt.Fprint(GinkgoWriter, out)
+			}
 		})
 
 		It("should reconcile function in dedicated namespaces", func() {
@@ -210,19 +241,21 @@ var _ = Describe("Bundle", Ordered, func() {
 		})
 
 		AfterAll(func() {
-			By("Uninstalling the operator from " + namespace1)
-			out, err := utils.OperatorSdkRun("cleanup",
-				"--namespace", namespace1,
-				"--delete-operator-groups")
-			Expect(err).NotTo(HaveOccurred())
-			_, _ = fmt.Fprint(GinkgoWriter, out)
-
-			By("Uninstalling the operator from " + namespace3)
-			out, err = utils.OperatorSdkRun("cleanup",
-				"--namespace", namespace3,
-				"--delete-all")
-			Expect(err).NotTo(HaveOccurred())
-			_, _ = fmt.Fprint(GinkgoWriter, out)
+			specReport := CurrentSpecReport()
+			if !specReport.Failed() {
+				By("Uninstalling the operator from " + namespace1)
+				out, err := utils.OperatorSdkRun("cleanup",
+					"--namespace", namespace1,
+					"--delete-operator-groups") // dont delete CRDs, as operator in ns3 still has them
+				Expect(err).NotTo(HaveOccurred())
+				_, _ = fmt.Fprint(GinkgoWriter, out)
+
+				By("Uninstalling the operator from " + namespace3)
+				out, err = utils.OperatorSdkRun("cleanup",
+					"--namespace", namespace3)
+				Expect(err).NotTo(HaveOccurred())
+				_, _ = fmt.Fprint(GinkgoWriter, out)
+			}
 		})
 
 		It("should reconcile function in dedicated namespaces", func() {
@@ -248,12 +281,14 @@ var _ = Describe("Bundle", Ordered, func() {
 		})
 
 		AfterAll(func() {
-			By("Uninstalling the operator")
-			out, err := utils.OperatorSdkRun("cleanup",
-				"--namespace", namespace1,
-				"--delete-all")
-			Expect(err).NotTo(HaveOccurred())
-			_, _ = fmt.Fprint(GinkgoWriter, out)
+			specReport := CurrentSpecReport()
+			if !specReport.Failed() {
+				By("Uninstalling the operator")
+				out, err := utils.OperatorSdkRun("cleanup",
+					"--namespace", namespace1)
+				Expect(err).NotTo(HaveOccurred())
+				_, _ = fmt.Fprint(GinkgoWriter, out)
+			}
 		})
 
 		It("should reconcile function in all namespaces", func() {