fix(winget): remove hardcoded en-US locale from getVersionManifests

getLocale endpoints now read DefaultLocale from the version manifest
and use getDefaultLocaleManifestPath to construct the correct locale
file path, instead of relying on a hardcoded en-US assumption.

Author: DemoMacro

server/routes/api/winget/packageManifests/[id].ts

@@ -8,6 +8,7 @@ import {
   buildPackageIndex,
   fetchManifestContent,
   getVersionManifests,
+  getDefaultLocaleManifestPath,
   createWinGetError,
 } from "../../../../utils/winget";
 
@@ -116,13 +117,23 @@ export default defineHandler(async (event: H3Event) => {
           versionEntry.DefaultLocale = parsed.DefaultLocale;
           versionEntry.Channel = parsed.Channel;
           versionEntry.Manifest = parsed;
+
+          // Fetch locale manifest using DefaultLocale from version manifest
+          if (parsed.DefaultLocale) {
+            try {
+              const localeContent = await fetchManifestContent(
+                getDefaultLocaleManifestPath(packageId, version, parsed.DefaultLocale),
+              );
+              const localeParsed = parseYAML(localeContent) as Record<string, any>;
+              if (!versionEntry.Locales) versionEntry.Locales = [];
+              versionEntry.Locales.push(localeParsed);
+            } catch {
+              // locale file may not exist
+            }
+          }
         } else if (filename.match(/\.installer\.yaml$/)) {
           // Installer manifest
           versionEntry.Installers = parsed.Installers;
-        } else if (filename.match(/\.locale\./)) {
-          // Locale manifest
-          if (!versionEntry.Locales) versionEntry.Locales = [];
-          versionEntry.Locales.push(parsed);
         }
       }
 

server/routes/api/winget/packages/[id]/versions/[version]/locales.ts

@@ -5,6 +5,7 @@ import { defineHandler, getRouterParam } from "nitro/h3";
 import type { LocaleMultipleResponse, LocaleSchema } from "../../../../../../../utils/winget";
 import {
   getVersionManifests,
+  getDefaultLocaleManifestPath,
   fetchManifestContent,
   createWinGetError,
 } from "../../../../../../../utils/winget";
@@ -91,27 +92,36 @@ export default defineHandler(async (event) => {
   // Find all locale manifests
   const locales: LocaleSchema[] = [];
 
-  for (const manifestPath of manifestFiles) {
-    const filename = manifestPath.split("/").pop()!;
+  // Read version manifest to get DefaultLocale
+  const versionManifestPath = manifestFiles.find(
+    (path) => path.split("/").pop() === `${packageId}.yaml`,
+  );
 
-    // Match locale files: {PackageId}.locale.{locale}.yaml
-    const localeMatch = filename.match(/\.locale\.([^.]+)\.yaml$/);
+  let defaultLocale = "en-US";
+  if (versionManifestPath) {
+    try {
+      const content = await fetchManifestContent(versionManifestPath);
+      const manifest = parseYAML(content) as Record<string, any>;
+      if (manifest.DefaultLocale) {
+        defaultLocale = manifest.DefaultLocale;
+      }
+    } catch {
+      // keep fallback
+    }
+  }
 
-    if (localeMatch && localeMatch[1]) {
-      const locale = localeMatch[1];
+  const localePath = getDefaultLocaleManifestPath(packageId, version, defaultLocale);
 
-      try {
-        const content = await fetchManifestContent(manifestPath);
-        const manifest = parseYAML(content) as Record<string, any>;
+  try {
+    const content = await fetchManifestContent(localePath);
+    const manifest = parseYAML(content) as Record<string, any>;
 
-        locales.push({
-          PackageLocale: locale,
-          ...manifest,
-        });
-      } catch {
-        locales.push({ PackageLocale: locale });
-      }
-    }
+    locales.push({
+      PackageLocale: defaultLocale,
+      ...manifest,
+    });
+  } catch {
+    locales.push({ PackageLocale: defaultLocale });
   }
 
   const response: LocaleMultipleResponse = {

server/routes/api/winget/packages/[id]/versions/[version]/locales/[locale].ts

@@ -5,6 +5,7 @@ import { defineHandler, getRouterParam } from "nitro/h3";
 import type { LocaleSingleResponse, LocaleSchema } from "../../../../../../../../utils/winget";
 import {
   getVersionManifests,
+  getDefaultLocaleManifestPath,
   fetchManifestContent,
   createWinGetError,
 } from "../../../../../../../../utils/winget";
@@ -95,17 +96,8 @@ export default defineHandler(async (event) => {
     return createWinGetError(event, 404, `Version ${version} of package '${packageId}' not found`);
   }
 
-  // Find the specific locale manifest
-  const localeFilename = `${packageId}.locale.${locale}.yaml`;
-  const localeManifestPath = manifestFiles.find((path) => path.split("/").pop() === localeFilename);
-
-  if (!localeManifestPath) {
-    return createWinGetError(
-      event,
-      404,
-      `Locale '${locale}' not found for version ${version} of package '${packageId}'`,
-    );
-  }
+  // Construct locale manifest path directly
+  const localeManifestPath = getDefaultLocaleManifestPath(packageId, version, locale);
 
   try {
     const content = await fetchManifestContent(localeManifestPath);
@@ -119,6 +111,14 @@ export default defineHandler(async (event) => {
 
     return response;
   } catch (error) {
-    return createWinGetError(event, 500, `Failed to parse locale manifest: ${String(error)}`);
+    const message = String(error);
+    if (message.includes("404")) {
+      return createWinGetError(
+        event,
+        404,
+        `Locale '${locale}' not found for version ${version} of package '${packageId}'`,
+      );
+    }
+    return createWinGetError(event, 500, `Failed to parse locale manifest: ${message}`);
   }
 });

server/utils/winget.ts

@@ -402,11 +402,7 @@ export function getVersionManifests(
 
   const basePath = `manifests/${letter}/${publisher}/${name}/${version}`;
 
-  return [
-    `${basePath}/${packageId}.yaml`,
-    `${basePath}/${packageId}.installer.yaml`,
-    `${basePath}/${packageId}.locale.en-US.yaml`,
-  ];
+  return [`${basePath}/${packageId}.yaml`, `${basePath}/${packageId}.installer.yaml`];
 }
 
 /**