Skip to content

consume_internal_message does not return SpedPast #134

Description

@wilkuz

crates/flux/src/spine/consumer.rs line 376, the SpedPast arm does not currently return or log anything on SpedPast

    #[inline]
    pub fn consume_internal_message<P, R, F>(
        &mut self,
        producers: &mut P,
        mut read: F,
    ) -> DCacheRead<InternalMessage<T>, R>
    where
        P: SpineProducers,
        F: FnMut(&InternalMessage<T>, &[u8]) -> R,
    {
        loop {
            match self.inner.try_consume_with_epoch() {
               ...
                Err(ReadError::SpedPast) => {
                    self.inner.recover_after_error();
                    return DCacheRead::SpedPast // This should be added
                }
               ... 
        }
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions