Skip to content

Commit 872e49a

Browse files
author
Yesh
committed
Fix SA changes
1 parent 105a0d7 commit 872e49a

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

cicd-mcp-server/cloudbuild/cloudbuild.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ func setPermissionsForCloudBuildSA(ctx context.Context, projectID, serviceAccoun
140140
"roles/run.developer",
141141
"roles/serviceusage.serviceUsageConsumer",
142142
"roles/storage.admin",
143-
"roles/iam.serviceAccountUser",
144143
}
145144
for _, r := range gcbSARoles {
146145
_, err := iamClient.AddIAMRoleBinding(ctx, fmt.Sprintf("projects/%s", projectID), r, resolvedSA)
@@ -174,6 +173,12 @@ func setPermissionsForCloudBuildSA(ctx context.Context, projectID, serviceAccoun
174173
}
175174
}
176175

176+
// 4. Grant the cloud build SA permissions to impersonate our p4sa.
177+
_, err = iamClient.AddIAMRoleBinding(ctx, resolvedSA, "roles/iam.serviceAccountUser", gcbP4sa)
178+
if err != nil {
179+
return "", fmt.Errorf("unable to add iam.serviceAccountUser role to Cloud Build P4SA %s on SA %s err: %w", gcbP4sa, resolvedSA, err)
180+
}
181+
177182
return resolvedSA, nil
178183
}
179184

0 commit comments

Comments
 (0)