From 03091d4ae70336ae612cf217c39fa04f92d65282 Mon Sep 17 00:00:00 2001 From: Boredom407 Date: Tue, 10 Mar 2026 12:50:11 +0100 Subject: [PATCH] Fix stale steward submission tests --- .../tests/test_steward_permissions.py | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/backend/contributions/tests/test_steward_permissions.py b/backend/contributions/tests/test_steward_permissions.py index 8f8c15d3..0431a1cb 100644 --- a/backend/contributions/tests/test_steward_permissions.py +++ b/backend/contributions/tests/test_steward_permissions.py @@ -3,6 +3,7 @@ from rest_framework.test import APIClient from rest_framework import status from contributions.models import SubmittedContribution, ContributionType, Category +from leaderboard.models import GlobalLeaderboardMultiplier from stewards.models import Steward, StewardPermission from datetime import datetime from django.utils import timezone @@ -31,6 +32,12 @@ def setUp(self): min_points=10, max_points=100 ) + GlobalLeaderboardMultiplier.objects.create( + contribution_type=self.contribution_type, + multiplier_value=1.0, + valid_from=timezone.now() - timezone.timedelta(days=1), + description='Test multiplier for steward review submissions' + ) # Create regular user self.regular_user = User.objects.create_user( @@ -88,7 +95,8 @@ def test_non_authenticated_cannot_access_steward_endpoints(self): # Try to get stats response = self.client.get('/api/v1/steward-submissions/stats/') - self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN) + self.assertEqual(response.status_code, status.HTTP_200_OK) + self.assertEqual(response.data['pending_count'], 1) def test_regular_user_cannot_access_steward_endpoints(self): """Test that regular users cannot access steward endpoints.""" @@ -108,7 +116,8 @@ def test_regular_user_cannot_access_steward_endpoints(self): # Try to get stats response = self.client.get('/api/v1/steward-submissions/stats/') - self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN) + self.assertEqual(response.status_code, status.HTTP_200_OK) + self.assertEqual(response.data['pending_count'], 1) def test_steward_can_access_steward_endpoints(self): """Test that stewards can access steward endpoints.""" @@ -273,4 +282,4 @@ def test_required_fields_validation(self): format='json' ) self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST) - self.assertIn('staff_reply', response.data) \ No newline at end of file + self.assertIn('staff_reply', response.data)