fix: address best-practice deviations and inconsistencies across features (#123)

* fix: address best-practice deviations and inconsistencies across features

Agent-Logs-Url: https://github.com/georglauterbach/dev-container-features/sessions/eda26b99-e515-4676-998c-d52485b321a1

Co-authored-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>

* chore: bump versions of `lang-rust` and `lang-sh`

Signed-off-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>

---------

Signed-off-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>

Author: Copilot

src/hermes/install.sh

@@ -1,7 +1,5 @@
 #! /bin/sh
 
-# shellcheck disable=SC2154
-
 set -e -u
 
 mkdir -p        /usr/local/bin/

src/lang-rust/README.md

@@ -38,7 +38,7 @@ To enable pretty printing in the debugger, add the setting
 
 ```jsonc
 "lldb.launch.preRunCommands": [
-  "command script import ${containerEnv:DCF_LANG_RUST_LLDB_PRETTIFIER}"
+  "command script import ${containerEnv:DCF_LANG_RUST_DIR}/lldb_prettifier.py"
 ]
 ```
 

src/lang-rust/devcontainer-feature.json

@@ -1,6 +1,6 @@
 {
   "id": "lang-rust",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "name": "Programming Language | Rust",
   "documentationURL": "https://github.com/georglauterbach/dev-container-features/tree/main/src/lang-rust",
   "description": "This Feature provides language support for Rust.",

src/lang-rust/install.sh

@@ -33,7 +33,7 @@ rustup_adjustments() {
 
 copy_lldb_prettifiers() {
   cp "scripts/lldb_prettifier.py.txt" "${DCF_LANG_RUST_DIR}/lldb_prettifier.py"
-  chmod 777 "${DCF_LANG_RUST_DIR}/lldb_prettifier.py"
+  chmod 644 "${DCF_LANG_RUST_DIR}/lldb_prettifier.py"
 }
 
 main() {

src/lang-sh/devcontainer-feature.json

@@ -1,14 +1,14 @@
 // cSpell: ignore timonwong
 {
   "id": "lang-sh",
-  "version": "0.5.0",
+  "version": "0.6.0",
   "name": "Programming Language | Shell",
   "documentationURL": "https://github.com/georglauterbach/dev-container-features/tree/main/src/lang-sh",
   "description": "This Feature provides language support for Shell.",
   "containerEnv": {
     // can be used to easily source 'libbash' by running
     // 'source "${DCF_LANG_SH_DIR}/libbash" [<LIBBASH ARGUMENTS>...]'
-    "DCF_LANG_SH_DIR": "/usr/local/share/dev_containers/features/ghcr.io/georglauterbach/lang_sh"
+    "DCF_LANG_SH_DIR": "/usr/local/share/dev_containers/features/ghcr_io/georglauterbach/lang_sh"
   },
   "customizations": {
     "vscode": {

src/lang-sh/install.sh

@@ -2,7 +2,7 @@
 
 set -e -u
 
-readonly DCF_LANG_SH_DIR=/usr/local/share/dev_containers/features/ghcr.io/georglauterbach/lang_sh
+readonly DCF_LANG_SH_DIR=/usr/local/share/dev_containers/features/ghcr_io/georglauterbach/lang_sh
 
 mkdir -p                         "${DCF_LANG_SH_DIR}"
 cp configuration/shellcheck.conf "${DCF_LANG_SH_DIR}"

src/vscode-cache-extensions/README.md

@@ -1,7 +1,7 @@
 
 # VS Code | Cache Extensions (vscode-cache-extensions)
 
-This Fearure prevents superfluous (re-)installations of VS Code extensions upon container restarts.
+This Feature prevents superfluous (re-)installations of VS Code extensions upon container restarts.
 
 ## Example Usage
 

src/vscode-cache-extensions/install.sh

@@ -13,7 +13,7 @@ fi
 
 # We create the mount point and temporary directories here with the
 # correct permissions. This is imperative for the mount point as
-# the volume mount will cary over the _permissions_ of an existing
+# the volume mount will carry over the _permissions_ of an existing
 # directory. We _cannot_ use `chown` here because of
 # `updateRemoteUserUID: true` in some cases, which would result in
 # a UID mismatch; hence, we need `777` as the permissions.