From 796a976a36dabace0df1c1ffbb229fe2b20448fd Mon Sep 17 00:00:00 2001
From: Bird + Keyboard <gitlab@birdkeyboard.com>
Date: Mon, 4 May 2020 19:36:30 -0400
Subject: [PATCH] Add alt attribute on blog logo and on banner images

For banner images, it will default to the post title, but with the ability to manually set one using the imageAlt property in the markdown header
---
 js/summerb146.js                  |  4 ++--
 templates/categories.html.twig    |  2 +-
 templates/featured.html.twig      |  2 +-
 templates/page.html.twig          |  2 +-
 templates/partials/base.html.twig |  2 +-
 templates/post.html.twig          | 10 ++++++++--
 6 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/js/summerb146.js b/js/summerb146.js
index 4821164..fca303d 100755
--- a/js/summerb146.js
+++ b/js/summerb146.js
@@ -47,9 +47,9 @@ var summer = (function ($) {
     },
 
     postHeaderCoverImg = function () {
-        var coverImage = $('[alt=cover-image]');
+        var coverImage = $('#cover-image');
         if (coverImage.length) {
-            $(postCoverImg).append('<img src="' + coverImage.attr('src') + '">');
+            $(postCoverImg).append('<img src="' + coverImage.attr('src') + '" alt="' + coverImage.attr('alt') + '">');
             coverImage.remove();
         }
     },
diff --git a/templates/categories.html.twig b/templates/categories.html.twig
index 8142cbb..9a43d0b 100644
--- a/templates/categories.html.twig
+++ b/templates/categories.html.twig
@@ -9,7 +9,7 @@
         <header class="summer-page-header">
             <div class="summer-page-menu-header">
                 <a class="summer-blog-logo" href="{{ base_url_absolute }}">
-                    <img src="{{ base_url_relative }}{{ site.logo }}" alt="Blog Logo" />
+                    <img src="{{ base_url_relative }}{{ site.logo }}" alt="{{ site.title }}" />
                 </a>
 
                 {% include 'partials/navigation.html.twig' %}
diff --git a/templates/featured.html.twig b/templates/featured.html.twig
index dee40f4..600edc2 100644
--- a/templates/featured.html.twig
+++ b/templates/featured.html.twig
@@ -9,7 +9,7 @@
         <header class="summer-page-header">
             <div class="summer-page-menu-header">
                 <a class="summer-blog-logo" href="{{ base_url_absolute }}">
-                    <img src="{{ base_url_relative }}{{ site.logo }}" alt="Blog Logo" />
+                    <img src="{{ base_url_relative }}{{ site.logo }}" alt="{{ site.title }}" />
                 </a>
 
                 {% include 'partials/navigation.html.twig' %}
diff --git a/templates/page.html.twig b/templates/page.html.twig
index 7d84974..7d09f17 100644
--- a/templates/page.html.twig
+++ b/templates/page.html.twig
@@ -9,7 +9,7 @@
         <header class="summer-page-header">
             <div class="summer-page-menu-header">
                 <a class="summer-blog-logo" href="{{ basebase_url_absolute_url }}">
-                    <img src="{{ base_url }}{{ site.logo }}" alt="Blog Logo" /></a>
+                    <img src="{{ base_url }}{{ site.logo }}" alt="{{ site.title }}" /></a>
                 </a>
 
                 {% include 'partials/navigation.html.twig' %}
diff --git a/templates/partials/base.html.twig b/templates/partials/base.html.twig
index eda9eaf..bf02c87 100644
--- a/templates/partials/base.html.twig
+++ b/templates/partials/base.html.twig
@@ -56,7 +56,7 @@
         {% block header %}
             <header class="summer-site-head">
                 <div class="summer-site-head-menu">
-                    <a class="summer-blog-logo" href="{{ base_url == '' ? '/' : base_url }}"><img src="{{ base_url_relative }}{{ site.logo }}" alt="Blog Logo" /></a>
+                    <a class="summer-blog-logo" href="{{ base_url == '' ? '/' : base_url }}"><img src="{{ base_url_relative }}{{ site.logo }}" alt="{{ site.title }}" /></a>
                     {% include 'partials/navigation.html.twig' %}
                     <div class="clearfix"></div>
                 </div>
diff --git a/templates/post.html.twig b/templates/post.html.twig
index a7885e2..6c5f152 100644
--- a/templates/post.html.twig
+++ b/templates/post.html.twig
@@ -6,12 +6,13 @@
 {% block header %}{% endblock %}
 
 {% block content %}
+
  <main id="summer-post-container" class="summer-post-container intro-effect-sliced" role="main">
   <header class="summer-post-header">
     <div class="bg-img"></div>
     <div class="summer-post-menu-header">
       <a class="summer-blog-logo" href="{{ base_url_absolute }}">
-        <img src="{{ base_url }}{{ site.logo }}" alt="Blog Logo" />
+        <img src="{{ base_url }}{{ site.logo }}" alt="{{ site.title }}" />
       </a>
       {% include 'partials/navigation.html.twig' %}
     </div>
@@ -24,7 +25,12 @@
 
   <button class="trigger bg-check" data-info="Read more"><span>Trigger</span></button>
 
-  {% if page.header.image %}<img src="{{ page.media[page.header.image].url }}" alt="cover-image" />{% endif %}
+  {% set headerAlt = page.title %}
+  {% if page.header.imageAlt %}
+    {% set headerAlt = page.header.imageAlt %}
+  {% endif %}
+
+  {% if page.header.image %}<img src="{{ page.media[page.header.image].url }}" id="cover-image" alt="{{ headerAlt }}" />{% endif %}
 
     <article class="summer-post-content post">
       <div>